Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

finalize deprecation of "closed"-parameter #9882

Merged
merged 5 commits into from
Dec 13, 2024
Merged

finalize deprecation of "closed"-parameter #9882

merged 5 commits into from
Dec 13, 2024

Conversation

kmuehlbauer
Copy link
Contributor

  • User visible changes (including notable bug fixes) are documented in whats-new.rst

@kmuehlbauer kmuehlbauer marked this pull request as ready for review December 13, 2024 11:45
@kmuehlbauer
Copy link
Contributor Author

kmuehlbauer commented Dec 13, 2024 •
edited
Loading

Over in #9618 I'm going to add unit-parameter to these functions. Finalizing the deprecation cycle before that.

Update: Instead of adding this in #9618 I'll open another PR after this one is in.

@dcherian
Copy link
Contributor

Merging quickly to unblock Kai.

@dcherian dcherian merged commit b7e6036 into pydata:main Dec 13, 2024
29 checks passed
@kmuehlbauer kmuehlbauer deleted the closed-inclusive-deprecation branch December 13, 2024 15:57
This was referenced Dec 16, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kmuehlbauer @dcherian