Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix for case of combining identical non-monotonic coords #3151

Merged
merged 5 commits into from
Jul 31, 2019
Merged

Hotfix for case of combining identical non-monotonic coords #3151

merged 5 commits into from
Jul 31, 2019

Conversation

TomNicholas
Copy link
Member

@TomNicholas TomNicholas mentioned this pull request Jul 20, 2019
Closed
@dcherian
Copy link
Contributor

LGTM

@TomNicholas
Copy link
Member Author

@dcherian yes lets. Does it need a what's new entry or is it good to go?

@max-sixty
Copy link
Collaborator

Are the test failures a one-off? Master does pass atm

@TomNicholas
Copy link
Member Author

I re-ran them and they passed.

@dcherian
Copy link
Contributor

Yes let's add a line under Bug Fixes. Feel free to merge

@TomNicholas TomNicholas merged commit e520534 into pydata:master Jul 31, 2019
dcherian added a commit to dcherian/xarray that referenced this pull request Aug 1, 2019
@dcherian
Merge branch 'master' into concat-join
386eecd 
* master:
  More annotations in Dataset (pydata#3112)
  Hotfix for case of combining identical non-monotonic coords (pydata#3151)
  changed url for rasterio network test (pydata#3162)
dcherian added a commit to yohai/xarray that referenced this pull request Aug 3, 2019
@dcherian
Merge branch 'master' into yohai-ds_scatter
318abaa 
* master: (68 commits)
  enable sphinx.ext.napoleon (pydata#3180)
  remove type annotations from autodoc method signatures (pydata#3179)
  Fix regression: IndexVariable.copy(deep=True) casts dtype=U to object (pydata#3095)
  Fix distributed.Client.compute applied to DataArray (pydata#3173)
  More annotations in Dataset (pydata#3112)
  Hotfix for case of combining identical non-monotonic coords (pydata#3151)
  changed url for rasterio network test (pydata#3162)
  to_zarr(append_dim='dim0') doesn't need mode='a' (pydata#3123)
  BUG: fix+test groupby on empty DataArray raises StopIteration (pydata#3156)
  Temporarily remove pynio from py36 CI build (pydata#3157)
  missing 'about' field (pydata#3146)
  Fix h5py version printing (pydata#3145)
  Remove the matplotlib=3.0 constraint from py36.yml (pydata#3143)
  disable codecov comments (pydata#3140)
  Merge broadcast_like docstrings, analyze implementation problem (pydata#3130)
  Update whats-new for pydata#3125 and pydata#2334 (pydata#3135)
  Fix tests on big-endian systems (pydata#3125)
  XFAIL tests failing on ARM (pydata#2334)
  Add broadcast_like. (pydata#3086)
  Better docs and errors about expand_dims() view (pydata#3114)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

xr.combine_by_coords raises ValueError if identical coordinates are non-monotonic
3 participants
@TomNicholas @dcherian @max-sixty