Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XFAIL tests failing on ARM #2334

Merged
merged 2 commits into from
Jul 15, 2019
Merged

XFAIL tests failing on ARM #2334

merged 2 commits into from
Jul 15, 2019

Conversation

ginggs
Copy link
Contributor

@ginggs ginggs commented Aug 1, 2018

These tests are expected to fail on ARM due to the following issue in NumPy:
numpy/numpy#8325

  • Tests added (for all bug fixes or enhancements)
  • Tests passed (for all non-documentation changes)

@@ -44,6 +44,9 @@
except ImportError:
pass

import platform
arm_xfail = pytest.mark.xfail(platform.machine() == 'aarch64' or
'arm' in platform.machine(), reason='expected failure on ARM')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E128 continuation line under-indented for visual indent

These tests are expected to fail on ARM due to the following issue in NumPy:
numpy/numpy#8325
@pep8speaks
Copy link

pep8speaks commented Jul 14, 2019

Hello @ginggs! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-07-14 16:19:19 UTC

@codecov
Copy link

codecov bot commented Jul 14, 2019

Codecov Report

Merging #2334 into master will decrease coverage by 0.9%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2334      +/-   ##
==========================================
- Coverage   95.98%   95.08%   -0.91%     
==========================================
  Files          63       63              
  Lines       12777    12777              
==========================================
- Hits        12264    12149     -115     
- Misses        513      628     +115

@max-sixty max-sixty mentioned this pull request Jul 15, 2019
2 tasks
@shoyer shoyer merged commit 3ceb038 into pydata:master Jul 15, 2019
@ginggs ginggs deleted the arm-xfail branch July 15, 2019 19:20
max-sixty pushed a commit that referenced this pull request Jul 15, 2019
dcherian added a commit to yohai/xarray that referenced this pull request Aug 3, 2019
* master: (68 commits)
  enable sphinx.ext.napoleon (pydata#3180)
  remove type annotations from autodoc method signatures (pydata#3179)
  Fix regression: IndexVariable.copy(deep=True) casts dtype=U to object (pydata#3095)
  Fix distributed.Client.compute applied to DataArray (pydata#3173)
  More annotations in Dataset (pydata#3112)
  Hotfix for case of combining identical non-monotonic coords (pydata#3151)
  changed url for rasterio network test (pydata#3162)
  to_zarr(append_dim='dim0') doesn't need mode='a' (pydata#3123)
  BUG: fix+test groupby on empty DataArray raises StopIteration (pydata#3156)
  Temporarily remove pynio from py36 CI build (pydata#3157)
  missing 'about' field (pydata#3146)
  Fix h5py version printing (pydata#3145)
  Remove the matplotlib=3.0 constraint from py36.yml (pydata#3143)
  disable codecov comments (pydata#3140)
  Merge broadcast_like docstrings, analyze implementation problem (pydata#3130)
  Update whats-new for pydata#3125 and pydata#2334 (pydata#3135)
  Fix tests on big-endian systems (pydata#3125)
  XFAIL tests failing on ARM (pydata#2334)
  Add broadcast_like. (pydata#3086)
  Better docs and errors about expand_dims() view (pydata#3114)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants