Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flake fixed #2629

Merged
merged 8 commits into from
Dec 25, 2018
Merged

Flake fixed #2629

merged 8 commits into from
Dec 25, 2018

Conversation

max-sixty
Copy link
Collaborator

Towards #2627

shoyer
shoyer requested changes Dec 24, 2018
View reviewed changes
xarray/backends/netcdf3.py Show resolved Hide resolved
xarray/core/dataset.py Outdated
@@ -2905,7 +2906,7 @@ def reduce(self, func, dim=None, keep_attrs=None, numeric_only=False,
else:
dims = set(dim)

missing_dimensions = [dim for dim in dims if dim not in self.dims]
missing_dimensions = [dim for d in dims if d not in self.dims]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here and below: This looks like a mistake -- dim is no longer the loop variable.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@max-sixty
Copy link
Collaborator Author

Let's merge this to ensure we don't have merge errors, and then answer #2627 (comment) after?

@shoyer shoyer merged commit 2667deb into pydata:master Dec 25, 2018
@shoyer
Copy link
Member

shoyer commented Dec 25, 2018

Thanks @max-sixty!

dcherian pushed a commit to yohai/xarray that referenced this pull request Jan 2, 2019
Merge branch 'master' into yohai-ds_scatter
faf4302 
* master:
  DEP: drop python 2 support and associated ci mods (pydata#2637)
  TST: silence warnings from bottleneck (pydata#2638)
  revert to dev version
  DOC: fix docstrings and doc build for 0.11.1
  Source encoding always set when opening datasets (pydata#2626)
  Add flake check to travis (pydata#2632)
  Fix dayofweek and dayofyear attributes from dates generated by cftime_range (pydata#2633)
  silence import warning (pydata#2635)
  fill_value in shift (pydata#2470)
  Flake fixed (pydata#2629)
  Allow passing of positional arguments in `apply` for Groupby objects (pydata#2413)
  Fix failure in time encoding for pandas < 0.21.1 (pydata#2630)
  Fix multiindex selection (pydata#2621)
  Close files when CachingFileManager is garbage collected (pydata#2595)
  added some logic to deal with rasterio objects in addition to filepaths (pydata#2589)
  Get 0d slices of ndarrays directly from indexing (pydata#2625)
  FIX Don't raise a deprecation warning for xarray.ufuncs.{angle,iscomplex} (pydata#2615)
  CF: also decode time bounds when available (pydata#2571)
@max-sixty max-sixty deleted the flake branch June 10, 2019 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shoyer shoyer shoyer requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@max-sixty @shoyer