Source encoding always set when opening datasets #2626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @TomNicholas! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on December 23, 2018 at 20:05 Hours UTC |
…las/xarray into feature/source_encoding
This reverts commit 7858799.
shoyer
reviewed
Dec 23, 2018
dcherian
reviewed
Dec 28, 2018
| @@ -61,6 +61,9 @@ Enhancements | |||
| - :py:meth:`DataArray.resample` and :py:meth:`Dataset.resample` now supports the | |||
| ``loffset`` kwarg just like Pandas. | |||
| By `Deepak Cherian <https://github.com/dcherian>`_ | |||
| - Datasets are now guaranteed to have a ``'source'`` encoding, so the source | |||
There was a problem hiding this comment.
Suggested change
| - Datasets are now guaranteed to have a ``'source'`` encoding, so the source | |
| - Datasets are now guaranteed to have an ``encoding.source`` attribute, so the source |
There was a problem hiding this comment.
You can't do attribute lookups in encoding, so encoding.source isn't valid.
There was a problem hiding this comment.
Oh right. So encoding['source'] then?
There was a problem hiding this comment.
Yep, encoding['source'] would work
|
I think the what's new entry could be a little clearer and it would be good to add this to the docs somewhere. Here's one option: http://xarray.pydata.org/en/stable/io.html?highlight=encoding#reading-encoded-data LGTM otherwise |
|
I pushed a commit with a few doc additions, will merge shortly. |
|
thanks! |
dcherian
pushed a commit
to yohai/xarray
that referenced
this pull request
Jan 2, 2019
* master: DEP: drop python 2 support and associated ci mods (pydata#2637) TST: silence warnings from bottleneck (pydata#2638) revert to dev version DOC: fix docstrings and doc build for 0.11.1 Source encoding always set when opening datasets (pydata#2626) Add flake check to travis (pydata#2632) Fix dayofweek and dayofyear attributes from dates generated by cftime_range (pydata#2633) silence import warning (pydata#2635) fill_value in shift (pydata#2470) Flake fixed (pydata#2629) Allow passing of positional arguments in `apply` for Groupby objects (pydata#2413) Fix failure in time encoding for pandas < 0.21.1 (pydata#2630) Fix multiindex selection (pydata#2621) Close files when CachingFileManager is garbage collected (pydata#2595) added some logic to deal with rasterio objects in addition to filepaths (pydata#2589) Get 0d slices of ndarrays directly from indexing (pydata#2625) FIX Don't raise a deprecation warning for xarray.ufuncs.{angle,iscomplex} (pydata#2615) CF: also decode time bounds when available (pydata#2571)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2550 by ensuring that the filename is always stored in the encoding dictionary of a dataset, under
'source'. Previously this feature would be backend-dependent.This was motivated by wanting the
preprocessfunction passed toopen_mfdatasetto have access to the filename of the dataset it is operating on. A specific use case is when you are opening a spatial grid of datasets, and want to apply a different operation to datasets at the edge of the grid (e.g. to deal with guard cells). It is therefore also relevant for discussion in #2159.whats-new.rstfor all changes andapi.rstfor new API