-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add classes for multi-theme content support #673
Conversation
This is looking great to me - one quick idea, though I think it'd be ok to move this to another PR: I think the most common image people will want to use for this is the logo in the top left. So I wonder if we could support another top-level config like "html_logo_dark", and place this next to the current logo, and add the respective theme selectors. That would allow users to have light and dark logos |
I was thinking about that as well but I think it deserves it's own PR if you could open another issue and assign it to me so that I don't forget that would be perfect |
Done here: #674 ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cleaned up the explanation a little bit - I hope that's OK!
It looks good to me though 👍
Hmm can we choose a different sample image? The |
|
huh weird - maybe my internet was just messing up...OK then I think we are good to go here :-) |
FIx #658
As suggested by @choldgraf, The theme is now allowing the devs to use
only-dark
andonly-light
to use different images based on the selected mode.It works with any elements (I'll use it for example to render multiple instance of jupyterlite in one of my documentation). Thus it's not documentated in images section but in the customization section.
Let me know if you think about any loopholes.
PS: the doc demo: https://pydata-sphinx-theme--673.org.readthedocs.build/en/673/user_guide/customizing.html#use-specific-content-in-each-theme