You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In #673 we are adding classes to support theme-specific images, content, etc. Basically, the classes will make an image display: none when the opposing theme is active.
A common use-case for theme-specific content is images, and this is one case where it'd be trickier for users to use this functionality.
Proposal
We should make it possible for users to define a "Dark Theme logo" that would be added to the site HTML with the dark-only class, and make our current html_logo image use the light-only class.
I think that the place to implement this would be in our navbar logo component:
Context
In #673 we are adding classes to support theme-specific images, content, etc. Basically, the classes will make an image
display: none
when the opposing theme is active.A common use-case for theme-specific content is images, and this is one case where it'd be trickier for users to use this functionality.
Proposal
We should make it possible for users to define a "Dark Theme logo" that would be added to the site HTML with the
dark-only
class, and make our currenthtml_logo
image use thelight-only
class.I think that the place to implement this would be in our
navbar logo
component:pydata-sphinx-theme/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/components/navbar-logo.html
Lines 1 to 19 in b806673
And maybe the simplest config would be to also support an
html_logo_dark
configuration instead of justhtml_logo
.The text was updated successfully, but these errors were encountered: