Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the footer inlined #632

Closed
wants to merge 2 commits into from
Closed

make the footer inlined #632

wants to merge 2 commits into from

Conversation

12rambau
Copy link
Collaborator

Fix #625

Display the footer inlined with automatic vertical pipes.

@choldgraf
Copy link
Collaborator

Hmm - my thinking is that this might be a little bit too opinionated for others. The intuitive default (to me anyway) is that the footer is block-level content rather than inline. Maybe this could be a short piece of sample documentation instead of hardcoding CSS in the theme?

@12rambau
Copy link
Collaborator Author

Hmm - my thinking is that this might be a little bit too opinionated for others. The intuitive default (to me anyway) is that the footer is block-level content rather than inline. Maybe this could be a short piece of sample documentation instead of hardcoding CSS in the theme?

sure I just wrote the PR not to forget it. Let me see if I can set it somewhere as an example

@damianavila
Copy link
Collaborator

Hmm - my thinking is that this might be a little bit too opinionated for others. The intuitive default (to me anyway) is that the footer is block-level content rather than inline.

Well... I actually see an improvement in what this PR proposes... 😉
Probably a totally subjective view as well...

@12rambau
Copy link
Collaborator Author

I wanted to make a poll but in the end, I think it's better to keep it that way and describe exactly how the trick can be performed as it's easier to start from a block-level and add css pipes and inline rules than the other way around.

@choldgraf
Copy link
Collaborator

as it's easier to start from a block-level and add css pipes and inline rules than the other way around

That's what I was thinking as well. Though if we can find some other themes that use behavior like this, something we can use as a guideline or principle to point to, then I'd be happy to discuss making it the default. Either way, documenting it is a nice start 🙂

@damianavila
Copy link
Collaborator

I think it's better to keep it that way and describe exactly how the trick can be performed as it's easier to start from a block-level and add css pipes and inline rules than the other way around.

Either way, documenting it is a nice start 🙂

I agree, let's go with docs as a first step!
@12rambau do you plan to use this very same branch/PR to work on the docs or should I close this one?

@12rambau
Copy link
Collaborator Author

I'll create another one for convenience

@12rambau 12rambau closed this Apr 21, 2022
@12rambau 12rambau deleted the footer branch May 11, 2022 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

display the footer on one line (when possible)?
3 participants