-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make the footer inlined #632
Conversation
Hmm - my thinking is that this might be a little bit too opinionated for others. The intuitive default (to me anyway) is that the footer is block-level content rather than inline. Maybe this could be a short piece of sample documentation instead of hardcoding CSS in the theme? |
sure I just wrote the PR not to forget it. Let me see if I can set it somewhere as an example |
Well... I actually see an improvement in what this PR proposes... 😉 |
I wanted to make a poll but in the end, I think it's better to keep it that way and describe exactly how the trick can be performed as it's easier to start from a block-level and add css pipes and inline rules than the other way around. |
That's what I was thinking as well. Though if we can find some other themes that use behavior like this, something we can use as a guideline or principle to point to, then I'd be happy to discuss making it the default. Either way, documenting it is a nice start 🙂 |
I agree, let's go with docs as a first step! |
I'll create another one for convenience |
Fix #625
Display the footer inlined with automatic vertical pipes.