Make skip_on_exception a signature-preserving decorator; issue 363
#364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bashtage
reviewed
Jul 6, 2017
tox.ini
Outdated
| wrapt |
There was a problem hiding this comment.
changed, but the tests passed even without the new line
bashtage
reviewed
Jul 6, 2017
tox.ini
Outdated
| @@ -7,3 +7,4 @@ commands= | |||
| deps= | |||
| pytest | |||
| pytest-cov | |||
| wrapt | |||
There was a problem hiding this comment.
Should be
deps=
pytest
pytest-cov
wrapt
so that the left column is vertically aligned.
There was a problem hiding this comment.
thanks, it was a tab, replaced with spaces, probably need to set it up in my editor
jreback
reviewed
Jul 6, 2017
| @@ -2,7 +2,7 @@ | |||
| Utilities for testing purposes. | |||
There was a problem hiding this comment.
don't change the mode of the file, use
git update-index --chmod -x <file> to put it back
There was a problem hiding this comment.
was offline for a while, it's already merged.
|
minor change, otherwise lgtm. ping on green. |
|
thanks! |
|
merged via 6cce5f1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #363
using wrapt package