Skip to content
This repository has been archived by the owner on Nov 18, 2021. It is now read-only.

Allow to correct a pull request in a user profile #988

Open
OlegShteynbuk opened this issue Aug 4, 2017 · 0 comments
Open

Allow to correct a pull request in a user profile #988

OlegShteynbuk opened this issue Aug 4, 2017 · 0 comments

Comments

@OlegShteynbuk
Copy link

OlegShteynbuk commented Aug 4, 2017

Sometimes a manually merged pull request could be displayed as a closed/rejected one. In my profile, a manually merged PR pydata/pandas-datareader#364 is next to the successfully merged one, which is so nicely displayed that the difference is difficult not to notice.

I have contacted GitHub support team in the hope that there is a way to correct how manually merged PR is displayed, below is their response:

GitHub tracks manual merges when the SHAs that are committed to the base branch match the SHAs that are part of the Pull Request -- however if the SHAs change because of a local rebase or squash, the manual merge will not be tracked.

We don't currently have a feature that would allow for changing that Pull Request to display a merge state on GitHub.com and the behavior here is intended, but we've made a note of your request around this so that the team can consider it when implementing future improvements to merging PRs on GitHub.

There are two open issues with proposed solutions. The first one is a UI solution and the second one is a console solution:

The first issue has been open for over 4 years.

This feature could be made available only to support team, or a designated user, or with some other restrictions. With all the good intentions there should be a way to correct a mistake.

If you are a software developer a PR could well be the most important part of your profile, and you don't want a PR to be represented as a bad or rejected code when reality could be quite opposite.

@OlegShteynbuk OlegShteynbuk changed the title Make it possible to correct a pull request in a user profile Allow to correct a pull request in a user profile Aug 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant