Add LIBSODIUM_MAKE_ARGS environment variable #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reaperhulk
approved these changes
Jun 13, 2017
Codecov Report
@@ Coverage Diff @@
## master #303 +/- ##
==========================================
- Coverage 99.86% 99.86% -0.01%
==========================================
Files 36 36
Lines 1448 1446 -2
Branches 71 71
==========================================
- Hits 1446 1444 -2
Misses 1 1
Partials 1 1
Continue to review full report at Codecov.
|
|
coverage numbers don't make sense so merging :) thanks again |
collivier
added a commit
to collivier/functest
that referenced
this pull request
May 12, 2019
Building functest-core container sometimes reach travis-ci timeout [0]. It decreases the compile time as proposed upstream [1] [0] https://travis-ci.org/collivier/functest/jobs/531417730 [1] pyca/pynacl#303 Change-Id: Ie6c8e729f76c98c6f8c8e9ca01b2c998081f7ce8 Signed-off-by: Cédric Ollivier <[email protected]>
collivier
added a commit
to collivier/functest
that referenced
this pull request
May 13, 2019
Building functest-core container sometimes reaches travis-ci timeout [0]. It decreases the compile time as proposed upstream [1]. [0] https://travis-ci.org/collivier/functest/jobs/531417730 [1] pyca/pynacl#303 Change-Id: Ie6c8e729f76c98c6f8c8e9ca01b2c998081f7ce8 Signed-off-by: Cédric Ollivier <[email protected]>
collivier
added a commit
to collivier/functest
that referenced
this pull request
May 22, 2019
Building functest-core container sometimes reaches travis-ci timeout [0]. It decreases the compile time as proposed upstream [1]. [0] https://travis-ci.org/collivier/functest/jobs/531417730 [1] pyca/pynacl#303 Change-Id: Ie6c8e729f76c98c6f8c8e9ca01b2c998081f7ce8 Signed-off-by: Cédric Ollivier <[email protected]>
collivier
added a commit
to collivier/functest
that referenced
this pull request
May 22, 2019
Building functest-core container sometimes reaches travis-ci timeout [0]. It decreases the compile time as proposed upstream [1]. [0] https://travis-ci.org/collivier/functest/jobs/531417730 [1] pyca/pynacl#303 Change-Id: Ie6c8e729f76c98c6f8c8e9ca01b2c998081f7ce8 Signed-off-by: Cédric Ollivier <[email protected]>
b23prodtm
added a commit
to b23prodtm/acake2php
that referenced
this pull request
Sep 11, 2019
b23prodtm
added a commit
to b23prodtm/acake2php
that referenced
this pull request
Sep 11, 2019
b23prodtm
added a commit
to b23prodtm/acake2php
that referenced
this pull request
Dec 10, 2019
DIND + DC Composer php extension setup fix Docker no space left on device Docker tags build-compose Optimized docker built primary.dind images Docker-Compose install with pynacl : pyca/pynacl#303
b23prodtm
added a commit
to b23prodtm/acake2php
that referenced
this pull request
Dec 10, 2019
Composer php extension setup fix Docker no space left on device Docker tags build-compose Optimized docker built primary.dind images Docker-Compose install with pynacl : pyca/pynacl#303
b23prodtm
added a commit
to b23prodtm/acake2php
that referenced
this pull request
Feb 28, 2020
author b23production GNU <[email protected]> 1567975413 +0200 committer Tiana Rakoto Arimanana <[email protected]> 1582920287 +0100 DIND + DC Composer php extension setup fix Docker no space left on device Docker tags build-compose Optimized docker built primary.dind images Docker-Compose install with pynacl : pyca/pynacl#303 php.ini error Multi Arch Build Enable disable balena arch dependent container block in YML Workaround logger device /dev/log balena-sound No docker layer caching (not a free feature) Export -f function not allowed in docker Alias /dev/log on docker machine logger balena docker hub Discard sub project Persistance No prompt CI build up Docker Hub build Circle dockerhub WIP Fix No package 'oniguruma' found https://github.com/mlocati/docker-php-extension-installer configure script cross-compile added aarch64 pushed to balena.io Deploy scripts Cross-build disable apache2 php7 : New deployments
b23prodtm
added a commit
to b23prodtm/acake2php
that referenced
this pull request
Feb 28, 2020
Composer php extension setup fix Docker no space left on device Docker tags build-compose Optimized docker built primary.dind images Docker-Compose install with pynacl : pyca/pynacl#303 php.ini error Multi Arch Build Enable disable balena arch dependent container block in YML Workaround logger device /dev/log balena-sound No docker layer caching (not a free feature) Export -f function not allowed in docker Alias /dev/log on docker machine logger balena docker hub Discard sub project Persistance No prompt CI build up Docker Hub build Circle dockerhub WIP Fix No package 'oniguruma' found https://github.com/mlocati/docker-php-extension-installer configure script cross-compile added aarch64 pushed to balena.io Deploy scripts Cross-build disable apache2 php7 : New deployments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By allowing a user to pass LIBSODIUM_MAKE_ARGS, we can decrease the compile time on slow platforms by a considerable amount.
In a
multiarch/alpine:armhf-v3.6docker container:pip install .takes about 10 minutesLIBSODIUM_MAKE_ARGS=-j4 pip install .takes just under 4 minutesFixes #302