Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libsodium slow build time #302

Closed
uSpike opened this issue Jun 13, 2017 · 5 comments · Fixed by #303
Closed

libsodium slow build time #302

uSpike opened this issue Jun 13, 2017 · 5 comments · Fixed by #303

Comments

@uSpike
Copy link
Contributor

uSpike commented Jun 13, 2017

Hi,

I am running into an issue where installing pynacl on a raspberry pi or in a multiarch docker container is very slow. By default, make (https://github.com/pyca/pynacl/blob/master/setup.py#L163) is run in one thread. Compile times could be reduced substantially (from >10 minutes to 1 minute in testing) by passing -j4 or higher to make.

Would the maintainers entertain the idea of an environment variable such as LIBSODIUM_MAKE_ARGS which could be passed like LIBSODIUM_MAKE_ARGS=-j4 pip install pynacl?
@reaperhulk
Copy link
Member

Yes I would be willing to review and merge such a patch.

@uSpike uSpike mentioned this issue Jun 13, 2017
Merged
@uSpike
Copy link
Contributor Author

uSpike commented Jun 19, 2017

Thanks for merging. Sorry for the noise, but just wondering when a new release might be done which contains this patch?

@reaperhulk
Copy link
Member

We'll ship this with 1.2.0, which will hopefully be ready in a week or two!

@mishas mishas mentioned this issue Jun 25, 2017
Closed
@Ajaythepower1606
Copy link

Brother it is really takeing too much time to install

It is showing
Building wheel for pynacl (PEP 517) ... -

@Ajaythepower1606
Copy link

It had taken more then 30min but still installing

@Lucas-C Lucas-C mentioned this issue Jul 8, 2020
Merged
reaperhulk pushed a commit that referenced this issue Jul 16, 2020
@Lucas-C
Doc: add a "Faster wheel build" section in INSTALL.rst (#602)
10b191d 
* Doc: add a "Faster wheel build" section in INSTALL.rst

Reference: #302

* Update INSTALL.rst

* Update INSTALL.rst
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add LIBSODIUM_MAKE_ARGS environment variable uSpike/pynacl
3 participants
@reaperhulk @uSpike @Ajaythepower1606