remove deprecated items #3794
Merged
remove deprecated items #3794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whirlpool, ripemd160, unsupportedextension, and the old interfaces
alex
requested changes
Jul 18, 2017
CHANGELOG.rst
Outdated
| @@ -6,6 +6,9 @@ Changelog | |||
|
|
|||
| .. note:: This version is not yet released and is under active development. | |||
|
|
|||
| * **BACKWARDS INCOMPATIBLE:** ``Whirlpool``, ``RIPEMD160``, and | |||
| ``UnsupportedExtension`` have been removed. | |||
There was a problem hiding this comment.
MACContext as well?
This should be clear they were already deprecated.
There was a problem hiding this comment.
We haven't removed MACContext, just moved it. Not sure how to phrase that.
There was a problem hiding this comment.
Oh, right. Uhh, yeah, that's fine.
There was a problem hiding this comment.
The bit about making clear they were deprecated still stands.
|
There's also some unused imports, and |
alex
approved these changes
Jul 18, 2017
|
I don't understand what's going on with docs on macOS? |
|
Ok, I wonder if this a segfault in pyenchant's wheels because x86 instructions or something. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whirlpool, ripemd160, unsupportedextension, and the old interfaces
followup PR will remove RIPEMD160 and Whirlpool test vectors.
fixes #3793