Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signer/Verifier deprecation warning has wrong stacklevel #3798

Closed
nchammas opened this issue Jul 19, 2017 · 4 comments
Closed

Signer/Verifier deprecation warning has wrong stacklevel #3798

nchammas opened this issue Jul 19, 2017 · 4 comments
Milestone
Twenty first release

Comments

@nchammas
Copy link

Seeing this with Cryptography 2.0:

.../python3.5/site-packages/cryptography/hazmat/backends/openssl/rsa.py:477: DeprecationWarning: signer and verifier have been deprecated. Please use sign and verify instead.
  _warn_sign_verify_deprecated()
.../python3.5/site-packages/cryptography/hazmat/backends/openssl/rsa.py:382: DeprecationWarning: signer and verifier have been deprecated. Please use sign and verify instead.
  _warn_sign_verify_deprecated()

I see a few open issues related to deprecations (e.g. #3794), but I'm not sure if any of them cover this particular message.
@alex
Copy link
Member

alex commented Jul 19, 2017

These are intentional, cryptography is emitting them! Though it looks like we got the stacklevel argument wrong. Whatever package is using cryptography should port itself to use the sign and verify methods.

I'm going to retitle this bug to be about updating the stacklevel we use.

@alex alex changed the title DeprecationWarning: signer and verifier have been deprecated Signer/Verifier deprecation warning has wrong stacklevel Jul 19, 2017
@nchammas
Copy link
Author

Ah, I thought Cryptography was using some deprecated methods within itself (which, on reflection, would be weird). I'll check downstream (I'm guessing Paramiko?) and open issues on the appropriate project if necessary.

@alex
Copy link
Member

alex commented Jul 19, 2017

@nchammas paramiko/paramiko#979

@alex
Copy link
Member

alex commented Jul 19, 2017

Hopefully fixing stacklevel will make this more obvious for folks.

@alex alex added this to the Twenty first release milestone Jul 19, 2017
alex added a commit that referenced this issue Jul 21, 2017
@alex
Fixed #3798 -- use the correct stacklevel on this warning
61d338d
reaperhulk pushed a commit to reaperhulk/cryptography that referenced this issue Jul 26, 2017
@alex @reaperhulk
Fixed pyca#3798 -- use the correct stacklevel on this warning (pyca#3803
9946c8d 
)
alex pushed a commit that referenced this issue Jul 26, 2017
@reaperhulk @alex
Fixed #3798 -- use the correct stacklevel on this warning (#3803) (#3819
9a20f65 
)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
Twenty first release
Development

No branches or pull requests
2 participants
@alex @nchammas