Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release automation fixes #3646

Closed
reaperhulk opened this issue May 30, 2017 · 8 comments
Closed

Release automation fixes #3646

reaperhulk opened this issue May 30, 2017 · 8 comments

Comments

@reaperhulk
Copy link
Member

With the new release.py the following issues occurred during the 1.9 release:

  • git tag -s failed until I signed something separately (to prime gpg-agent's password caching for signing?)
  • both twine uploads failed

At least some of this may be unfortunate interaction with gpg-agent/gnupg2 for signing (but the second twine command was purely uploading wheels so not sure why that failed)

@alex
Copy link
Member

alex commented Jun 2, 2017

Immediate action item is to make sure failures include the stderr in the error message so that we can debug.

alex added a commit that referenced this issue Jun 4, 2017
reaperhulk pushed a commit that referenced this issue Jun 4, 2017
@reaperhulk
Copy link
Member Author

The combination of gnupg2 and git requires GPG_TTY to be set to work properly. So at least git tag -s should work now (and we'll see about twine)

@reaperhulk
Copy link
Member Author

twine uploads still failed in the 2.0 release. Here's the output:

Exception: (['twine', 'upload', '-s', 'dist/cryptography-2.0*', 'vectors/dist/cryptography_vectors-2.0*'], 2, b'usage: twine [-h] [--version] {register,upload}\ntwine: error: the following arguments are required: command, args\n')

Additionally, triggering the wheel builder failed with

requests.exceptions.HTTPError: 405 Client Error: Method Not Allowed for url: https://ci.cryptography.io/job/cryptography-support-jobs/job/wheel-builder/build?querystringremoved

@alex
Copy link
Member

alex commented Jul 17, 2017

Ok, the problem with uploads is that we should not be using globs, I will take fixing that.

@reaperhulk
Copy link
Member Author

The twine invocation to upload the wheels also failed and it does not use globs. No useful traceback came out of that though 😢

@alex
Copy link
Member

alex commented Jul 17, 2017

That was diagnosed as "we pass all the paths as a single space separated string in argv, instead of in N argv entries":

https://github.com/pyca/cryptography/blob/master/release.py#L136

that should be run("twine", "upload", *paths)

@alex
Copy link
Member

alex commented Jul 17, 2017

(And I'll send a PR for that as soon as we're reopened master for dev)

@alex
Copy link
Member

alex commented Jul 24, 2017

I think everything here is fixed.

@alex alex closed this as completed Jul 24, 2017
reaperhulk pushed a commit to reaperhulk/cryptography that referenced this issue Jul 26, 2017
reaperhulk pushed a commit to reaperhulk/cryptography that referenced this issue Jul 26, 2017
alex pushed a commit that referenced this issue Jul 26, 2017
* Refs #3646 -- Don't use shell globbing in our release script (#3809)

* fix wheel building with parameters (#3808)

* Refs #3646 -- invoke twine correctly (#3789)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

2 participants