Refs pyca#3646 -- Don't use shell globbing in our release script

alex · Jul 23, 2017 · f48090f · f48090f
1 parent bacff94
commit f48090f
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/release.py b/release.py
@@ -5,6 +5,7 @@
 from __future__ import absolute_import, division, print_function
 
 import getpass
+import glob
 import io
 import os
 import subprocess
@@ -106,10 +107,11 @@ def release(version):
     run("python", "setup.py", "sdist")
     run("python", "setup.py", "sdist", "bdist_wheel", cwd="vectors/")
 
-    run(
-        "twine", "upload", "-s", "dist/cryptography-{0}*".format(version),
-        "vectors/dist/cryptography_vectors-{0}*".format(version), shell=True
+    packages = (
+        glob.glob("dist/cryptography-{0}*".format(version)) +
+        glob.glob("vectors/dist/cryptography_vectors-{0}*".format(version))
     )
+    run("twine", "upload", "-s", *packages)
 
     session = requests.Session()