Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] pup_uart and pup_dcm processes can get out of sync #1137

Closed
laurensvalk opened this issue Jul 3, 2023 · 1 comment · Fixed by pybricks/pybricks-micropython#179
Closed

[Bug] pup_uart and pup_dcm processes can get out of sync #1137

laurensvalk opened this issue Jul 3, 2023 · 1 comment · Fixed by pybricks/pybricks-micropython#179
Assignees
@laurensvalk
Labels
bug Something isn't working software: pybricks-micropython Issues with Pybricks MicroPython firmware (or EV3 runtime) topic: sensors Issues involving sensors

Comments

@laurensvalk
Copy link
Member

Describe the bug
Under some conditions, the device connection manager does not restart when the uartdev process fails.

On Technic Hub, this causes devices not to sync up on boot due to a separate (older) issue in #1134.

But we should fix this more generally to catch other failures as well.
@laurensvalk laurensvalk added triage Issues that have not been triaged yet topic: sensors Issues involving sensors software: pybricks-micropython Issues with Pybricks MicroPython firmware (or EV3 runtime) bug Something isn't working and removed triage Issues that have not been triaged yet labels Jul 3, 2023
@laurensvalk laurensvalk self-assigned this Jul 3, 2023
laurensvalk added a commit to pybricks/pybricks-micropython that referenced this issue Jul 4, 2023
@laurensvalk
pbio/drv/legodev: Replace unplug reset by watchdog.
2ed2a84 
This keeps the device connection manager in control even if the UART
device and PT threads get in a confused state.

Fixes pybricks/support#1137
laurensvalk added a commit to pybricks/pybricks-micropython that referenced this issue Jul 4, 2023
@laurensvalk
pbio/drv/legodev: Replace unplug reset by watchdog.
274ca6a 
This keeps the device connection manager in control even if the UART
device and PT threads get in a confused state.

Fixes pybricks/support#1137
@laurensvalk laurensvalk mentioned this issue Jul 4, 2023
Merged
@laurensvalk
Copy link
Member Author

This is restored to the original working state with pybricks/pybricks-micropython#179 but as discussed in the comments there, we could further clean this code to make it more robust and easier to follow. See #1140 for some ideas.

laurensvalk added a commit to pybricks/pybricks-micropython that referenced this issue Jul 4, 2023
@laurensvalk
pbio/drv/legodev: Replace unplug reset by watchdog.
2937e6d 
This keeps the device connection manager in control even if the UART
device and PT threads get in a confused state.

Fixes pybricks/support#1137
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laurensvalk laurensvalk

Labels
bug Something isn't working software: pybricks-micropython Issues with Pybricks MicroPython firmware (or EV3 runtime) topic: sensors Issues involving sensors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pbio/drv/legodev: Replace unplug reset by watchdog. pybricks/pybricks-micropython
1 participant
@laurensvalk