pbio/drv/legodev: Replace unplug reset by watchdog. #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlech
reviewed
Jul 4, 2023
|
Thanks for the review. It would be nice to get the sensors in a working state for now, while we can consider further separation as in e.g. pybricks/support#1140 as a follow up. |
laurensvalk
force-pushed
the
legodev-fixes
branch
from
274ca6a to
2937e6d
Compare
This keeps the device connection manager in control even if the UART device and PT threads get in a confused state. Fixes pybricks/support#1137
laurensvalk
force-pushed
the
legodev-fixes
branch
from
2937e6d to
dbd9175
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This keeps the device connection manager in control even if the UART device and PT threads get in a confused state.
Fixes pybricks/support#1137