Skip to content

Commit

Permalink
bricks/stm32: Revert "Force exit on IDE stop button."
Browse files Browse the repository at this point in the history
This reverts commit 7e9951d.

This caused existing user programs that expected finally clauses to run
on exit to break.

Fixes: pybricks/support#834
  • Loading branch information
dlech committed Dec 7, 2022
1 parent 45cc21f commit 3e50334
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,13 @@
- Fixed crash on calling methods on uninitialized objects ([support#805]).
- Fixed crash on calling methods in `__init__(self, ...)` before
calling `super().__init(...)` on uninitialized objects ([support#777]).
- Reverted Pybricks Code stop button raises `SystemAbort` instead of
`SystemExit` ([support#834]).

[support#777]: https://github.com/pybricks/support/issues/777
[support#805]: https://github.com/pybricks/support/issues/805
[support#826]: https://github.com/pybricks/support/issues/826
[support#834]: https://github.com/pybricks/support/issues/834


## [3.2.0b6] - 2022-12-02
Expand Down
2 changes: 1 addition & 1 deletion lib/pbio/sys/command.c
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ pbio_pybricks_error_t pbsys_command(const uint8_t *data, uint32_t size) {

switch (cmd) {
case PBIO_PYBRICKS_COMMAND_STOP_USER_PROGRAM:
pbsys_program_stop(true);
pbsys_program_stop(false);
return PBIO_PYBRICKS_ERROR_OK;
case PBIO_PYBRICKS_COMMAND_START_USER_PROGRAM:
return pbio_pybricks_error_from_pbio_error(pbsys_program_load_start_user_program());
Expand Down

0 comments on commit 3e50334

Please sign in to comment.