Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grouped SPMe edit #577

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Grouped SPMe edit #577

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c725295
Adding Battery voltage to the variables list for time domain simulati…
noelhallemans Dec 4, 2024
961734a
Delete Nyquist.png
noelhallemans Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions pybop/models/lithium_ion/basic_SPMe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,13 @@ def __init__(self, name="Single particle model with electrolyte", **model_kwargs
include_double_layer = self.options["surface form"] == "differential"

pybamm.citations.register("Chen2020") # for the OCPs
pybamm.citations.register("""
pybamm.citations.register(
"""
@article{HallemansPreprint,
title={{Hallemans Preprint}},
}
""")
"""
)

######################
# Variables
Expand Down Expand Up @@ -373,6 +375,7 @@ def __init__(self, name="Single particle model with electrolyte", **model_kwargs
"Discharge capacity [A.h]": Q,
"Throughput capacity [A.h]": Qt,
"Voltage [V]": V,
"Battery voltage [V]": V,
"Open-circuit voltage [V]": U_p - U_n,
}

Expand Down