Grouped SPMe edit #577
Merged
Grouped SPMe edit #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolaCourtier
added a commit
that referenced
this pull request
Dec 11, 2024
* Add first go at grouped SPMe * Update thicknesses * Update overpotentials * Add double-layer * Update example * Remove factors of length * Fix domain parameters * Update series resistance and etas * Set constant conductivity * Remove factor of 3 * Add parameter conversion function * Combine plots * Update model options * Rename variables * Add conductivities and init_soc * Update averaging * Move timescales * Rescale electrolyte source * Assume high conductivities * Add electrolyte flux * Add transfer coefficient * Update grouped_SPMe * Revert to sto_e, make double layer optional * Add target continuity conditions * Simplify ocv_init setting * Remove concatenations * Switch from theoretical to measured capacity * Move example into subfolder * Fix electrolyte scaling * Add potentials to quick plot * Update option setting * Grouped SPMe edit (#577) * Add Battery voltage to the variables list * Create grouped_SPMe_experiment.py * Move set_initial_state to base models * Remove testing script * Add tests on GroupedSPMe * Test differential surface form * Fix option setting * Update README.md * Add test_grouped_SPMe * Increase coverage * Update name and option setting * Remove comments * Combine if statements * Update CHANGELOG.md --------- Co-authored-by: Noël Hallemans <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding "Battery voltage [V]" to the variables list for time domain experiments.