Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main -> develop #493

Merged
merged 21 commits into from
Sep 11, 2024
Merged
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
0630d0d
fixes to pybop.experiment, pybop.base_model for pybamm@develop ahead …
BradyPlanden May 5, 2024
775c3c0
increment number of states in spm_UKF example
BradyPlanden May 5, 2024
f03643f
fix: update non-converged DFN test
BradyPlanden May 22, 2024
9b4fd07
update target pybamm source to forked develop w/ diffusivity fix
BradyPlanden Jun 27, 2024
f7e5b7d
tests: updts to test_non_converged_solution.
BradyPlanden Jun 28, 2024
4b77f05
test: updt asserts to capture differing outputs
BradyPlanden Jun 28, 2024
c88a2ed
test: revert to allclose as output vector varies for each OS
BradyPlanden Jun 28, 2024
5484a6c
tests: remove gradient == np.inf assert
BradyPlanden Jun 28, 2024
4c71ed9
tests: Add missing asserts
BradyPlanden Jun 30, 2024
d95275f
build: increment pybamm to 24.5rc2, ci: increment tests alongside.
BradyPlanden Jul 22, 2024
4915404
tests: increase coverage, fix flaky observer tests
BradyPlanden Jul 20, 2024
baa9467
style: pre-commit fixes
pre-commit-ci[bot] Jul 22, 2024
963f563
Reverts linting changes for patch v24.6.1
BradyPlanden Jul 22, 2024
8c9823c
release: increment versions
BradyPlanden Jul 31, 2024
a318207
Apply suggestions from code review
BradyPlanden Jul 31, 2024
737a4f8
Merge pull request #415 from pybop-team/patch-pybammv24.5
BradyPlanden Jul 31, 2024
eefd9e7
fix: increment pyproject.toml verison
BradyPlanden Jul 31, 2024
2d8e6e1
increment version to v24.9.0
BradyPlanden Sep 10, 2024
fd4aa76
Merge branch 'refs/heads/main' into release-v24.9
BradyPlanden Sep 10, 2024
061fef9
patch fix: transformation integration test stability
BradyPlanden Sep 10, 2024
99632b9
Merge pull request #491 from pybop-team/release-v24.9
BradyPlanden Sep 11, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: updt asserts to capture differing outputs
BradyPlanden committed Jul 22, 2024
commit 4b77f0597341a5092d204a26df32aff8aafc59fb
5 changes: 3 additions & 2 deletions tests/unit/test_models.py
Original file line number Diff line number Diff line change
@@ -361,10 +361,11 @@ def test_non_converged_solution(self):
problem = pybop.FittingProblem(model, parameters=parameters, dataset=dataset)

# Simulate the DFN with active material values of 0.
# The solution from model.simulateS1 should be inf
# and the gradient should be inf.
# The solutions will not change as the solver will not converge.
output = problem.evaluate([0, 0])
output_S1, res_grad = problem.evaluateS1([0, 0])

for key in problem.signal:
assert np.allclose(output.get(key, [])[0], output.get(key, []))
assert np.isinf(output_S1.get(key, [])).any()
assert np.isinf(res_grad).any()