Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main -> develop #493

Merged
merged 21 commits into from
Sep 11, 2024
Merged

Main -> develop #493

merged 21 commits into from
Sep 11, 2024

Conversation

BradyPlanden
Copy link
Member

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Issue reference

Fixes # (issue-number)

Review

Before you mark your PR as ready for review, please ensure that you've considered the following:

  • Updated the CHANGELOG.md in reverse chronological order (newest at the top) with a concise description of the changes, including the PR number.
  • Noted any breaking changes, including details on how it might impact existing functionality.

Type of change

  • New Feature: A non-breaking change that adds new functionality.
  • Optimization: A code change that improves performance.
  • Examples: A change to existing or additional examples.
  • Bug Fix: A non-breaking change that addresses an issue.
  • Documentation: Updates to documentation or new documentation for new features.
  • Refactoring: Non-functional changes that improve the codebase.
  • Style: Non-functional changes related to code style (formatting, naming, etc).
  • Testing: Additional tests to improve coverage or confirm functionality.
  • Other: (Insert description of change)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All unit tests pass: $ nox -s tests
  • The documentation builds: $ nox -s doctest

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.

Further checks:

  • Code is well-commented, especially in complex or unclear areas.
  • Added tests that prove my fix is effective or that my feature works.
  • Checked that coverage remains or improves, and added tests if necessary to maintain or increase coverage.

Thank you for contributing to our project! Your efforts help us to deliver great software.

BradyPlanden and others added 21 commits July 22, 2024 11:51
Changes to pybamm v24.5 have resulted in solver.solve()
to return values for incorrect inputs values when not requesting
sensitivities. This removes the test that assert output == np.inf
in this case.
# Conflicts:
#	CHANGELOG.md
#	CITATION.cff
#	docs/_static/switcher.json
#	examples/scripts/spm_UKF.py
#	pybop/costs/fitting_costs.py
#	pybop/models/base_model.py
#	pyproject.toml
#	tests/unit/test_cost.py
#	tests/unit/test_models.py
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 99.51160% with 8 lines in your changes missing coverage. Please review.

Project coverage is 99.04%. Comparing base (97aba6f) to head (99632b9).
Report is 702 commits behind head on develop.

Files with missing lines Patch % Lines
pybop/_utils.py 98.61% 1 Missing ⚠️
pybop/models/lithium_ion/base_echem.py 95.23% 1 Missing ⚠️
pybop/parameters/parameter.py 98.64% 1 Missing ⚠️
pybop/parameters/priors.py 98.43% 1 Missing ⚠️
pybop/plotting/plotly_manager.py 75.00% 1 Missing ⚠️
pybop/problems/design_problem.py 97.36% 1 Missing ⚠️
pybop/samplers/mcmc_sampler.py 92.85% 1 Missing ⚠️
pybop/transformation/base_transformation.py 97.77% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #493      +/-   ##
===========================================
+ Coverage    97.78%   99.04%   +1.25%     
===========================================
  Files           43       52       +9     
  Lines         2579     3546     +967     
===========================================
+ Hits          2522     3512     +990     
+ Misses          57       34      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BradyPlanden BradyPlanden merged commit 1361e5c into develop Sep 11, 2024
36 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant