Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fitting functionality for geometric parameters #169

Merged
merged 19 commits into from
Feb 21, 2024

remove missed merge delete

8a17a99
Select commit
Loading
Failed to load commit list.
Merged

Add fitting functionality for geometric parameters #169

remove missed merge delete
8a17a99
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 21, 2024 in 0s

94.70% (+0.11%) compared to 45df796

View this Pull Request on Codecov

94.70% (+0.11%) compared to 45df796

Details

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (45df796) 94.58% compared to head (8a17a99) 94.70%.
Report is 17 commits behind head on develop.

Files Patch % Lines
pybop/models/base_model.py 93.87% 3 Missing ⚠️
pybop/_problem.py 91.66% 1 Missing ⚠️
pybop/parameters/parameter.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #169      +/-   ##
===========================================
+ Coverage    94.58%   94.70%   +0.11%     
===========================================
  Files           44       44              
  Lines         1829     1887      +58     
===========================================
+ Hits          1730     1787      +57     
- Misses          99      100       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.