-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fitting functionality for geometric parameters #169
Add fitting functionality for geometric parameters #169
Conversation
…ebuilding, updt. plot2D
…s, add rebuild parameters functionality to problem.evaluate(), updt. example
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #169 +/- ##
===========================================
+ Coverage 94.58% 94.70% +0.11%
===========================================
Files 44 44
Lines 1829 1887 +58
===========================================
+ Hits 1730 1787 +57
- Misses 99 100 +1 ☔ View full report in Codecov by Sentry. |
… change private reference to public in design example
…arameter cls, bigfix geometric logic in problem cls
Hi @NicolaCourtier, this should now be ready for review. I've updated the spm_CMAES.py example to be geometric as a reference. Seems to be working fine, and isn't a massive hit on performance. |
Did you mean to change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks @BradyPlanden, don't forget the Changelog!
This PR adds functionality to fit geometric parameters in pybop. This essentially requires a model rebuild every iteration, but a combined effort to minimise the number of objects that get rebuilt. It completes the following:
rebuild()
method tobase_model
model.rebuild_parameters
set_rebuild_parameters()
to create the required dictionary of geometric parameterscopy()
method tobase_model
plot_cost2D()
Closes #18