Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a GITT fitting example #223

Closed
NicolaCourtier opened this issue Mar 1, 2024 · 1 comment · Fixed by #249
Closed

Add a GITT fitting example #223

NicolaCourtier opened this issue Mar 1, 2024 · 1 comment · Fixed by #249
Assignees
Labels
enhancement New feature or request

Comments

@NicolaCourtier
Copy link
Member

Feature description

Create an example workflow for fitting GITT test data.

Motivation

To demonstrate and benchmark a common battery parameterisation problem.

Possible implementation

This could be implemented as an example script/notebook or as an extension of the FittingProblem class.

Additional context

No response

@NicolaCourtier NicolaCourtier added the enhancement New feature or request label Mar 1, 2024
@brosaplanella
Copy link
Contributor

We did something similar in pybamm-param (see https://github.com/paramm-team/pybamm-param/blob/develop/pbparam/optimisation_problems/gitt.py). Happy to give it a go, as this would inform how to integrate both projects.

brosaplanella added a commit to brosaplanella/PyBOP that referenced this issue Mar 20, 2024
@BradyPlanden BradyPlanden moved this to Todo in v24.6 Mar 21, 2024
@BradyPlanden BradyPlanden moved this from Todo to In Progress in v24.6 Mar 21, 2024
brosaplanella added a commit to brosaplanella/PyBOP that referenced this issue Mar 25, 2024
brosaplanella added a commit to brosaplanella/PyBOP that referenced this issue Mar 25, 2024
brosaplanella added a commit to brosaplanella/PyBOP that referenced this issue Mar 25, 2024
brosaplanella added a commit to brosaplanella/PyBOP that referenced this issue Mar 25, 2024
brosaplanella added a commit to brosaplanella/PyBOP that referenced this issue Mar 25, 2024
brosaplanella added a commit to brosaplanella/PyBOP that referenced this issue Mar 25, 2024
brosaplanella added a commit to brosaplanella/PyBOP that referenced this issue Mar 30, 2024
brosaplanella added a commit to brosaplanella/PyBOP that referenced this issue Apr 8, 2024
brosaplanella added a commit to brosaplanella/PyBOP that referenced this issue Apr 8, 2024
brosaplanella added a commit to brosaplanella/PyBOP that referenced this issue Apr 8, 2024
brosaplanella added a commit to brosaplanella/PyBOP that referenced this issue May 15, 2024
brosaplanella added a commit to brosaplanella/PyBOP that referenced this issue May 15, 2024
brosaplanella added a commit to brosaplanella/PyBOP that referenced this issue May 15, 2024
brosaplanella added a commit to brosaplanella/PyBOP that referenced this issue May 15, 2024
brosaplanella added a commit to brosaplanella/PyBOP that referenced this issue May 15, 2024
brosaplanella added a commit to brosaplanella/PyBOP that referenced this issue May 16, 2024
brosaplanella added a commit to brosaplanella/PyBOP that referenced this issue May 16, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in v24.6 May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants