pybop-team#223 remove GITT class and move to example

brosaplanella · May 15, 2024 · d38b38f · d38b38f
1 parent 6a5ee3d
commit d38b38f
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 58 deletions.
diff --git a/examples/scripts/gitt.py b/examples/scripts/gitt.py
@@ -33,9 +33,24 @@
 )
 
 # Define the cost to optimise
-problem = pybop.GITT(
-    model="Weppner & Huggins", parameter_set=parameter_set, dataset=dataset
+model = pybop.lithium_ion.WeppnerHuggins(parameter_set=parameter_set)
+
+parameters = [
+    pybop.Parameter(
+        "Positive electrode diffusivity [m2.s-1]",
+        prior=pybop.Gaussian(5e-14, 1e-13),
+        bounds=[1e-16, 1e-11],
+        true_value=parameter_set["Positive electrode diffusivity [m2.s-1]"],
+    ),
+]
+
+problem = pybop.FittingProblem(
+    model,
+    parameters,
+    dataset,
+    signal=["Voltage [V]"],
 )
+
 cost = pybop.RootMeanSquaredError(problem)
 
 # Build the optimisation problem

diff --git a/pybop/problems/gitt.py b/pybop/problems/gitt.py