Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get module version from module_ctx and try to lookup integrities #103

Merged
merged 3 commits into from
Sep 27, 2024
Merged

Get module version from module_ctx and try to lookup integrities #103

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba8ff3f
Get module version from module_ctx and try to lookup integrities
lalten Aug 30, 2024
b58bafa
Merge remote-tracking branch 'origin/master' into integrities
lalten Sep 25, 2024
791b665
Add 2.13.6 and comment on how to generate the SRI
lalten Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions internal_configure.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,18 @@

load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

def _parse_my_own_version_from_module_dot_bazel(module_ctx):
lines = module_ctx.read(Label("//:MODULE.bazel")).split("\n")
for line in lines:
parts = line.split("\"")
if parts[0] == " version = ":
return parts[1]
fail("Failed to parse my own version from `MODULE.bazel`! " +
"This should never happen!")
_INTEGRITIES = {
# Generate with "sha256-$(curl -fsSL "$url" | sha256sum | cut -d' ' -f1 | xxd -r -p | base64)"
"2.11.1": "sha256-1HWXjaDNwtQ7c/MJEHhnWdWTqdjuBbG2hG0esWxtLgw=",
"2.12.0": "sha256-v48kKr0avNN11RanBnSQ+3Gr15UZooLSK25NGSghhac=",
"2.13.1": "sha256-UWMeiJYKiFb5xJcCf1XJ8vkRXK+wjAAFQ5g4oFuhe/w=",
"2.13.5": "sha256-seIJxCs6ntdNo+CyWk9M1HjYnV77tI8EsnffQn+vYlI=",
lalten marked this conversation as resolved.
Show resolved Hide resolved
"2.13.6": "sha256-4Iy4f0dz2pf6e18DXeh2OrxlbYfVdz5i9toFh9Hw7CA=",
}

def _internal_configure_extension_impl(module_ctx):
version = _parse_my_own_version_from_module_dot_bazel(module_ctx)
(pybind11_bazel,) = [module for module in module_ctx.modules if module.name == "pybind11_bazel"]
version = pybind11_bazel.version
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!


# The pybind11_bazel version should typically just be the pybind11 version,
# but can end with ".bzl.<N>" if the Bazel plumbing was updated separately.
Expand All @@ -21,7 +22,8 @@ def _internal_configure_extension_impl(module_ctx):
name = "pybind11",
build_file = "//:pybind11-BUILD.bazel",
strip_prefix = "pybind11-%s" % version,
urls = ["https://github.com/pybind/pybind11/archive/v%s.zip" % version],
url = "https://github.com/pybind/pybind11/archive/refs/tags/v%s.tar.gz" % version,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this Github's preferred linking scheme? The releases page shows URLs like https://github.com/pybind/pybind11_bazel/releases/download/v2.12.0/pybind11_bazel-2.12.0.tar.gz

Is there any documentation for my own education?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bazel-contrib/SIG-rules-authors#11 (comment)

However your releases/download URL version is even better because those artifacts are not generated by GitHub on demand but actual files attached to the release

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, it looks like there aren't actually any artifacts of that form for pybind11, only the generated ones. So will keep as is.
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The one you pointed at is this repo itself, which is doing a better job :)
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "Source code (...)" ones are generated by GitHub, anything else is manually uploaded as part of the release.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry my day job kept me very busy for a few days. This looks good, I'm going to merge it.

integrity = _INTEGRITIES.get(version),
)

internal_configure_extension = module_extension(implementation = _internal_configure_extension_impl)