Get module version from module_ctx and try to lookup integrities #103
Conversation
|
I'll find some cycles to look at this in the morning. |
|
Friendly bump |
| @@ -21,7 +20,8 @@ def _internal_configure_extension_impl(module_ctx): | |||
| name = "pybind11", | |||
| build_file = "//:pybind11-BUILD.bazel", | |||
| strip_prefix = "pybind11-%s" % version, | |||
| urls = ["https://github.com/pybind/pybind11/archive/v%s.zip" % version], | |||
| url = "https://github.com/pybind/pybind11/archive/refs/tags/v%s.tar.gz" % version, | |||
There was a problem hiding this comment.
Is this Github's preferred linking scheme? The releases page shows URLs like https://github.com/pybind/pybind11_bazel/releases/download/v2.12.0/pybind11_bazel-2.12.0.tar.gz
Is there any documentation for my own education?
There was a problem hiding this comment.
bazel-contrib/SIG-rules-authors#11 (comment)
However your releases/download URL version is even better because those artifacts are not generated by GitHub on demand but actual files attached to the release
There was a problem hiding this comment.
ah, it looks like there aren't actually any artifacts of that form for pybind11, only the generated ones. So will keep as is.
There was a problem hiding this comment.
The one you pointed at is this repo itself, which is doing a better job :)
There was a problem hiding this comment.
The "Source code (...)" ones are generated by GitHub, anything else is manually uploaded as part of the release.
There was a problem hiding this comment.
Sorry my day job kept me very busy for a few days. This looks good, I'm going to merge it.
|
|
||
| def _internal_configure_extension_impl(module_ctx): | ||
| version = _parse_my_own_version_from_module_dot_bazel(module_ctx) | ||
| (pybind11_bazel,) = [module for module in module_ctx.modules if module.name == "pybind11_bazel"] | ||
| version = pybind11_bazel.version |
| @@ -21,7 +20,8 @@ def _internal_configure_extension_impl(module_ctx): | |||
| name = "pybind11", | |||
| build_file = "//:pybind11-BUILD.bazel", | |||
| strip_prefix = "pybind11-%s" % version, | |||
| urls = ["https://github.com/pybind/pybind11/archive/v%s.zip" % version], | |||
| url = "https://github.com/pybind/pybind11/archive/refs/tags/v%s.tar.gz" % version, | |||
There was a problem hiding this comment.
Sorry my day job kept me very busy for a few days. This looks good, I'm going to merge it.
Fixes #102