Issue 834 sei models #974
Merged
Issue 834 sei models #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #974 +/- ##
===========================================
+ Coverage 97.48% 97.65% +0.17%
===========================================
Files 222 243 +21
Lines 11791 12593 +802
===========================================
+ Hits 11494 12298 +804
+ Misses 297 295 -2
Continue to review full report at Codecov.
|
brosaplanella
approved these changes
May 5, 2020
| pb.set_logging_level("INFO") | ||
| # pb.settings.debug_mode = True | ||
|
|
||
| options = {"sei": "reaction limited"} |
There was a problem hiding this comment.
Should we comment out all but one so users will know they only need one of them?
examples/scripts/sei_growth.py
Outdated
| # } | ||
| # ) | ||
|
|
||
| # parameter_values.update({"Current function [A]": 0}) |
There was a problem hiding this comment.
If the parameter values are already in the default, I think we should delete them from here to keep it simple.
| @@ -49,6 +49,11 @@ class BaseBatteryModel(pybamm.BaseModel): | |||
| variable for instead of solving in PyBaMM. The entries of the lists | |||
| are strings that correspond to the submodel names in the keys | |||
| of `self.submodels`. | |||
| * "sei" : str | |||
There was a problem hiding this comment.
We should give a reference for each model so people can check what the equations are.
| @@ -36,6 +36,58 @@ def set_standard_output_variables(self): | |||
| } | |||
| ) | |||
|
|
|||
| # def set_reactions(self): | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add SEI models
Just need to figure out the example (or remove?)
Fixes #834
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: