Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SEI long term growth models to PyBaMM #834

Closed
4 tasks
Scottmar93 opened this issue Feb 18, 2020 · 2 comments · Fixed by #974
Closed
4 tasks

Add SEI long term growth models to PyBaMM #834

Scottmar93 opened this issue Feb 18, 2020 · 2 comments · Fixed by #974
Assignees
@valentinsulzer @Scottmar93
Labels
feature

Comments

@Scottmar93
Copy link
Contributor

Scottmar93 commented Feb 18, 2020 •
edited
Loading

Add the following SEI long term growth models:

  • Reaction limited
  • Solvent-diffusion limited
  • Electron-migration limited
  • Lithium-interstitial-migration limited
@Scottmar93 Scottmar93 self-assigned this Feb 18, 2020
@valentinsulzer
Copy link
Member

feel free to untangle the interface submodels as part of this 😅

Scottmar93 added a commit that referenced this issue Feb 18, 2020
@Scottmar93
#834 making a start on SEI models
92800d9
Scottmar93 added a commit that referenced this issue Feb 18, 2020
@Scottmar93
#834 added a standard sei parameter file
f76e200
Scottmar93 added a commit that referenced this issue Feb 19, 2020
@Scottmar93
#834 correcting errors on reaction limited model
ac61e40
Scottmar93 added a commit that referenced this issue Feb 19, 2020
@Scottmar93
#834 seems to work
22124d4
Scottmar93 added a commit that referenced this issue Feb 19, 2020
@Scottmar93
#834 reaction limited runs but playing with parameters
d01ebd0
Scottmar93 added a commit that referenced this issue Mar 10, 2020
@Scottmar93
#834 playing with model parameters
20312ba
Scottmar93 added a commit that referenced this issue Mar 10, 2020
@Scottmar93
#834 modify input parameters
70c8891
Scottmar93 added a commit that referenced this issue Mar 13, 2020
@Scottmar93
#834 modified parameter values
b5c60a2
Scottmar93 added a commit that referenced this issue Mar 13, 2020
@Scottmar93
#834 coupled currents to macroscale
17edb36
Scottmar93 added a commit that referenced this issue Mar 13, 2020
@Scottmar93
#834 added solvent diffusion limited growth
b0dda1c
Scottmar93 added a commit that referenced this issue Mar 13, 2020
@Scottmar93
#834 added interstitial limited and electron limited growth
80669c7
valentinsulzer added a commit that referenced this issue Apr 8, 2020
@valentinsulzer
#834 merge develop
0b966bf
valentinsulzer added a commit that referenced this issue Apr 8, 2020
@valentinsulzer
#834 merge develop
2cdc949
@valentinsulzer
Copy link
Member

@Scottmar93 I'll try to get this cleaned up and merged (I have merged in #933 )

@valentinsulzer valentinsulzer self-assigned this Apr 24, 2020
valentinsulzer added a commit that referenced this issue Apr 24, 2020
@valentinsulzer
#834 remove parameters for no SEI
3b157a3
valentinsulzer added a commit that referenced this issue Apr 24, 2020
@valentinsulzer
#834 add tests to lithium-ion models
ea2eedd
@felipe-salinas felipe-salinas mentioned this issue Apr 27, 2020
Closed
@valentinsulzer valentinsulzer mentioned this issue Apr 29, 2020
Merged
8 tasks
valentinsulzer added a commit that referenced this issue May 5, 2020
@valentinsulzer
#834 ferran comments
a95c982
valentinsulzer added a commit that referenced this issue May 5, 2020
@valentinsulzer
#834 fix docs
e00f191
valentinsulzer added a commit that referenced this issue May 5, 2020
@valentinsulzer
#834 remove unused param
2d6eb19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valentinsulzer valentinsulzer

@Scottmar93 Scottmar93

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 834 sei models pybamm-team/PyBaMM
2 participants
@valentinsulzer @Scottmar93