-
-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 729 ecker params #922
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
Codecov Report
@@ Coverage Diff @@
## develop #922 +/- ##
========================================
Coverage 98.03% 98.04%
========================================
Files 208 216 +8
Lines 11016 11109 +93
========================================
+ Hits 10800 10892 +92
- Misses 216 217 +1
Continue to review full report at Codecov.
|
Description
Adds the parameter set from the Ecker papers:
Fixes #729
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: