Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ecker parameter set #729

Closed
Scottmar93 opened this issue Nov 13, 2019 · 1 comment · Fixed by #922
Closed

Add Ecker parameter set #729

Scottmar93 opened this issue Nov 13, 2019 · 1 comment · Fixed by #922
Assignees
@Scottmar93

Comments

@Scottmar93
Copy link
Contributor

Summary
Add the parameter set in: http://jes.ecsdl.org/content/162/9/A1836.full
@Scottmar93 Scottmar93 self-assigned this Nov 13, 2019
@rtimms
Copy link
Contributor

rtimms commented Nov 15, 2019

might make a nice notebook to compare with the experimental results from the paper too

Scottmar93 added a commit that referenced this issue Feb 11, 2020
@Scottmar93
#729 added data for ocp, diffusivity
6293dde
Scottmar93 added a commit that referenced this issue Feb 11, 2020
@Scottmar93
#729 added reaction rates
e096a23
Scottmar93 added a commit that referenced this issue Feb 11, 2020
@Scottmar93
#729 added electrolyte conductivity
9a41e29
Scottmar93 added a commit that referenced this issue Feb 11, 2020
@Scottmar93
#729 added electrolyte diffusivity
da2b416
Scottmar93 added a commit that referenced this issue Feb 11, 2020
@Scottmar93
#729 setting up tests for ecker set
c616bd5
Scottmar93 added a commit that referenced this issue Feb 11, 2020
@Scottmar93
#729 started experimental tortuosity class
865a92e
Scottmar93 added a commit that referenced this issue Feb 11, 2020
@Scottmar93
#729 added parameter set but doesn't work
d8aa59c
Scottmar93 added a commit that referenced this issue Feb 11, 2020
@Scottmar93
#729 tried to incrementally introduce parameters
bbba976
Scottmar93 added a commit that referenced this issue Feb 12, 2020
@Scottmar93
#729 tried adding entropic change functions
7203297
valentinsulzer added a commit that referenced this issue Feb 13, 2020
@valentinsulzer
#729 events fix
3e1f8e4
Scottmar93 added a commit that referenced this issue Feb 20, 2020
@Scottmar93
#729 made a number of corrections
b1eb67b
Scottmar93 added a commit that referenced this issue Feb 20, 2020
@Scottmar93
#729 updated diffusion
3bbeafa
rtimms added a commit that referenced this issue Mar 27, 2020
@rtimms
#729 add parameters
fcd29e1
rtimms added a commit that referenced this issue Mar 27, 2020
@rtimms
#729 add experimental data
5e9e3c9
@rtimms rtimms mentioned this issue Mar 27, 2020
Merged
8 tasks
rtimms added a commit that referenced this issue Mar 27, 2020
@rtimms
#729 changelog
7d69e7c
rtimms added a commit that referenced this issue Mar 30, 2020
@rtimms
#729 add dlnf param
8f3d905
rtimms added a commit that referenced this issue Mar 30, 2020
@rtimms
#729 merge develop
8803100
rtimms added a commit that referenced this issue Mar 30, 2020
@rtimms
#729 remove NULL functions
33cf784
rtimms added a commit that referenced this issue Mar 30, 2020
@rtimms
#729 update electrolyte params
5d001bd
rtimms added a commit that referenced this issue Mar 30, 2020
@rtimms
#729 fix cli example
887d08c
rtimms added a commit that referenced this issue Mar 30, 2020
@rtimms
#729 fix cli example
b10b20c
valentinsulzer added a commit that referenced this issue Mar 30, 2020
@valentinsulzer
#729 trying to fix cli
423e97e
valentinsulzer added a commit that referenced this issue Mar 30, 2020
@valentinsulzer
#729 trying to fix cli
26f616f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Scottmar93 Scottmar93

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 729 ecker params pybamm-team/PyBaMM
2 participants
@Scottmar93 @rtimms