Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw an error when concatenations have different number of children #4562

Merged
merged 13 commits into from
Nov 12, 2024
Merged

Throw an error when concatenations have different number of children #4562

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
b598da1
add error and test
aabills Nov 4, 2024
f4668b6
Merge branch 'develop' into concatenation-bug
kratman Nov 11, 2024
30a9547
disable thermal half cells for now
Nov 11, 2024
e4b7f5a
Merge branch 'develop' into concatenation-bug
kratman Nov 11, 2024
49a0c54
easier way to fix it
Nov 12, 2024
787b093
clean up
Nov 12, 2024
7dbeaae
move half cell code to function
Nov 12, 2024
e79aac9
style: pre-commit fixes
pre-commit-ci[bot] Nov 12, 2024
3b7aa40
Merge branch 'develop' into concatenation-bug
aabills Nov 12, 2024
e7bb5a3
Merge branch 'develop' into concatenation-bug
aabills Nov 12, 2024
2d83ec6
changelog
Nov 12, 2024
4cd3390
Update CHANGELOG.md
aabills Nov 12, 2024
f313159
Merge branch 'develop' into concatenation-bug
kratman Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## Features

- Added `CoupledVariable` which provides a placeholder variable whose equation can be elsewhere in the model. ([#4556](https://github.com/pybamm-team/PyBaMM/pull/4556))
- Adds support to `pybamm.Experiment` for the `output_variables` option in the `IDAKLUSolver`. ([#4534](https://github.com/pybamm-team/PyBaMM/pull/4534))
- Adds an option "voltage as a state" that can be "false" (default) or "true". If "true" adds an explicit algebraic equation for the voltage. ([#4507](https://github.com/pybamm-team/PyBaMM/pull/4507))
- Improved `QuickPlot` accuracy for simulations with Hermite interpolation. ([#4483](https://github.com/pybamm-team/PyBaMM/pull/4483))
Expand All @@ -21,6 +22,9 @@
- Removed the `start_step_offset` setting and disabled minimum `dt` warnings for drive cycles with the (`IDAKLUSolver`). ([#4416](https://github.com/pybamm-team/PyBaMM/pull/4416))

## Bug Fixes
- Added error for binary operators on two concatenations with different numbers of children. Previously, the extra children were dropped. ([#4562](https://github.com/pybamm-team/PyBaMM/pull/4562))
- Fixed bug where Q_rxn was dropped from the total heating term in half-cell models. ([#4562](https://github.com/pybamm-team/PyBaMM/pull/4562))
aabills marked this conversation as resolved.
Show resolved Hide resolved
- Fixed bug where Q_rxn was set to 0 for the negative electrode in half-cell models. ([#4557](https://github.com/pybamm-team/PyBaMM/pull/4557))
- Fixed bug in post-processing solutions with infeasible experiments using the (`IDAKLUSolver`). ([#4541](https://github.com/pybamm-team/PyBaMM/pull/4541))
- Disabled IREE on MacOS due to compatibility issues and added the CasADI
path to the environment to resolve issues on MacOS and Linux. Windows
Expand Down