Throw an error when concatenations have different number of children #4562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are going to fail on this due to an unrelated issue that I am working on concurrently, so opening this for now and once we merge the other one we can merge this one. |
aabills
changed the title
8 tasks
aabills
requested review from
brosaplanella,
DrSOKane,
rtimms,
valentinsulzer,
TomTranter and
martinjrobins
as code owners
kratman
reviewed
Nov 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4562 +/- ##
===========================================
- Coverage 99.27% 99.26% -0.02%
===========================================
Files 302 302
Lines 22868 22889 +21
===========================================
+ Hits 22703 22721 +18
- Misses 165 168 +3 ☔ View full report in Codecov by Sentry. |
kratman
previously approved these changes
Nov 11, 2024
kratman
reviewed
Nov 12, 2024
|
@aabills Can you update the bug fix section of the change log |
kratman
reviewed
Nov 12, 2024
kratman
previously approved these changes
Nov 12, 2024
Done, I realized I haven't done that for the other PR's either so I did all 3. |
kratman
reviewed
Nov 12, 2024
Co-authored-by: Eric G. Kratz <[email protected]>
kratman
approved these changes
Nov 12, 2024
pkalbhor
pushed a commit
to pkalbhor/PyBaMM
that referenced
this pull request
Nov 15, 2024
…ybamm-team#4562) * add error and test * disable thermal half cells for now * easier way to fix it * clean up * move half cell code to function * style: pre-commit fixes * changelog * Update CHANGELOG.md Co-authored-by: Eric G. Kratz <[email protected]> --------- Co-authored-by: Eric G. Kratz <[email protected]> Co-authored-by: Alexander Bills <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #4561
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run(or$ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all(or$ nox -s tests)$ python run-tests.py --doctest(or$ nox -s doctests)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick(or$ nox -s quick).Further checks: