Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make typing-extensions and sympy required dependencies to fix PyBaMM import #3848

Merged
merged 13 commits into from
Mar 5, 2024

Rearrange position in changelog

ad958a2
Select commit
Loading
Failed to load commit list.
Merged

Make typing-extensions and sympy required dependencies to fix PyBaMM import #3848

Rearrange position in changelog
ad958a2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 5, 2024 in 0s

99.60% (-0.01%) compared to ed6df7e, passed because coverage increased by +0.00% when compared to adjusted base (99.60%)

View this Pull Request on Codecov

99.60% (-0.01%) compared to ed6df7e, passed because coverage increased by +0.00% when compared to adjusted base (99.60%)

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.60%. Comparing base (ed6df7e) to head (ad958a2).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3848      +/-   ##
===========================================
- Coverage    99.60%   99.60%   -0.01%     
===========================================
  Files          259      259              
  Lines        21284    21261      -23     
===========================================
- Hits         21200    21177      -23     
  Misses          84       84              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.