Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use of last-state as starting-solution in Simulation.solve() #2822

Merged
merged 2 commits into from
Mar 29, 2023

Conversation

jsbrittain
Copy link
Contributor

Description

When a starting_solution was provided to Solution.solve(), the method attempted to pass a sub-field of the starting_solution to make_cycle_solution(), instead of the required list of Solver objects.

Fixes #2788 ([Bug]: Solution last_state can't be used as a starting solution)

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all
  • The documentation builds: $ python run-tests.py --doctest

You can run unit and doctests together at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c78bed2) 99.69% compared to head (ac47b03) 99.69%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2822   +/-   ##
========================================
  Coverage    99.69%   99.69%           
========================================
  Files          272      272           
  Lines        19035    19035           
========================================
  Hits         18976    18976           
  Misses          59       59           
Impacted Files Coverage Δ
pybamm/simulation.py 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jsbrittain jsbrittain marked this pull request as ready for review March 28, 2023 12:11
Copy link
Contributor

@martinjrobins martinjrobins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jsbrittain, happy to merge this

@martinjrobins martinjrobins merged commit 5d570ed into develop Mar 29, 2023
@martinjrobins martinjrobins deleted the issue-2788-last-state branch March 29, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Solution last_state can't be used as a starting solution
2 participants