Merge pull request #2822 from pybamm-team/issue-2788-last-state

Fix use of last-state as starting-solution in Simulation.solve()
pybamm-team · Mar 29, 2023 · 5d570ed · 5d570ed
2 parents c78bed2 + ac47b03
commit 5d570ed
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -15,6 +15,7 @@
 - Improved `model.latexify()` to have a cleaner and more readable output ([#2764](https://github.com/pybamm-team/PyBaMM/pull/2764))
 - Fixed electrolyte conservation in the case of concentration-dependent transference number ([#2758](https://github.com/pybamm-team/PyBaMM/pull/2758))
 - Fixed `plot_voltage_components` so that the sum of overpotentials is now equal to the voltage ([#2740](https://github.com/pybamm-team/PyBaMM/pull/2740))
+- Fixed use of last_state as starting_solution in Simulation.solve() ([#2822](https://github.com/pybamm-team/PyBaMM/pull/2822))
 
 ## Optimizations
 

diff --git a/pybamm/simulation.py b/pybamm/simulation.py
@@ -652,7 +652,7 @@ def solve(
                     cycle_sum_vars,
                     cycle_first_state,
                 ) = pybamm.make_cycle_solution(
-                    starting_solution.steps,
+                    [starting_solution],
                     esoh_solver=esoh_solver,
                     save_this_cycle=True,
                 )