Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily pin tox < 4 #2541

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Conversation

Saransh-cpp
Copy link
Member

@Saransh-cpp Saransh-cpp commented Dec 9, 2022

Description

#2537 might take some time, given that there are a lot of breaking changes and not all of them are documented well. Additionally, they have enabled isolated_builds to be always true, which I think is the reason for the failing ubuntu tests -

image

The macOS and windows tests work with v4 now, but the ubuntu tests don't.

This PR aims to temporarily fix the CI by upper-pinning tox (till the time tox.ini is migrated to v4).

Fixes # (issue)

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

Copy link
Member

@valentinsulzer valentinsulzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks like this worked!

@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Base: 99.72% // Head: 99.72% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (3961286) compared to base (b072d22).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop    #2541    +/-   ##
=========================================
  Coverage    99.72%   99.72%            
=========================================
  Files          268      270     +2     
  Lines        19315    19423   +108     
=========================================
+ Hits         19262    19370   +108     
  Misses          53       53            
Impacted Files Coverage Δ
pybamm/parameters/__init__.py 100.00% <0.00%> (ø)
pybamm/__init__.py 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@valentinsulzer valentinsulzer merged commit 812d393 into pybamm-team:develop Dec 9, 2022
@Saransh-cpp Saransh-cpp deleted the temp-tox branch December 9, 2022 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants