Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to tox 4.0 #2537

Closed
wants to merge 10 commits into from
Closed

Migrate to tox 4.0 #2537

wants to merge 10 commits into from

Conversation

Saransh-cpp
Copy link
Member

Description

Fixes # (issue)

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@Saransh-cpp Saransh-cpp changed the title Migrate tox to 4.0 Migrate to top 4.0 Dec 9, 2022
@Saransh-cpp Saransh-cpp changed the title Migrate to top 4.0 Migrate to tox 4.0 Dec 9, 2022
@Saransh-cpp
Copy link
Member Author

macOS looks okay now

@Saransh-cpp Saransh-cpp mentioned this pull request Dec 9, 2022
8 tasks
@Saransh-cpp
Copy link
Member Author

TODO:

  • Dig into isolated_build more, which is most probably causing the ubuntu tests to fail.
  • Update "tox<4" occurrences with tox

@Saransh-cpp Saransh-cpp marked this pull request as draft December 22, 2022 08:33
@valentinsulzer
Copy link
Member

@Saransh-cpp feel free to change to nox or other if you're more comfortable with it. tox is nice but none of us really know how to maintain it

@brosaplanella
Copy link
Member

Should we close this PR as we have now #3005 open?

@Saransh-cpp
Copy link
Member Author

Yes!

@Saransh-cpp Saransh-cpp deleted the tox branch August 20, 2023 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants