Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.4.0 #1447

Merged
merged 16 commits into from
Mar 26, 2021
Merged

Release 0.4.0 #1447

merged 16 commits into from
Mar 26, 2021

Conversation

valentinsulzer
Copy link
Member

Description

Increment version number and update changelog for relase 0.4.0

Also rename master to main

Copy link
Member

@brosaplanella brosaplanella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Tino!

CHANGELOG.md Outdated
- several new models, including reversible and irreversible plating submodels, submodels for loss of active material, Yang et al.'s (2017) coupled SEI/plating/pore clogging model, and the Newman-Tobias model
- internal optimizations for solving models, particularly for simulating experiments, with more accurate event detection and more efficient numerical methods and post-processing
- parallel solutions of a model with different inputs
- a cleaner installation process for Mac, no longer requiring a Homebrew installation of Sundials
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor point: maybe mention that this is true when installing from PyPI, otherwise maybe people installing from the repo will be confused. (Sundials is still required when installing from the repo)

a cleaner installation process for Mac when installing from PyPI, no longer requiring a local installation of Sundials

Copy link
Contributor

@tlestang tlestang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay! Just a very minor comment in the changelog, but I'm happy for this to be merged :)

@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #1447 (2551c87) into develop (64c6aad) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1447   +/-   ##
========================================
  Coverage    98.28%   98.28%           
========================================
  Files          281      281           
  Lines        16219    16219           
========================================
  Hits         15941    15941           
  Misses         278      278           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64c6aad...2551c87. Read the comment docs.

@valentinsulzer valentinsulzer merged commit e71a200 into develop Mar 26, 2021
@valentinsulzer valentinsulzer deleted the release-0.4.0 branch March 26, 2021 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants