Merge pull request #1444 from DrSOKane/LithiumPlating

Lithium plating
pybamm-team · Mar 26, 2021 · 64c6aad · 64c6aad
2 parents 42486f8 + 5cecb0a
commit 64c6aad
Show file tree

Hide file tree

Showing 8 changed files with 33 additions and 88 deletions.
diff --git a/examples/notebooks/lithium-plating.ipynb b/examples/notebooks/lithium-plating.ipynb
diff --git a/pybamm/input/parameters/lithium-ion/lithium_platings/okane2020_Li_plating/parameters.csv b/pybamm/input/parameters/lithium-ion/lithium_platings/okane2020_Li_plating/parameters.csv
@@ -3,6 +3,7 @@ Name [units],Value,Reference,Notes
 ,,,
 # Lithium plating parameters,,,
 Lithium metal partial molar volume [m3.mol-1],1.30E-05,Yang2017,
+Lithium plating kinetic rate constant [m.s-1],1E-10,,
 Exchange-current density for plating [A.m-2],[function]plating_exchange_current_density_OKane2020,,
 Exchange-current density for stripping [A.m-2],[function]stripping_exchange_current_density_OKane2020,,
 Initial plated lithium concentration [mol.m-3],0.00E+00,,
diff --git a/...m-ion/lithium_platings/okane2020_Li_plating/plating_exchange_current_density_OKane2020.py b/...m-ion/lithium_platings/okane2020_Li_plating/plating_exchange_current_density_OKane2020.py
@@ -1,4 +1,4 @@
-from pybamm import constants
+from pybamm import constants, Parameter
 
 
 def plating_exchange_current_density_OKane2020(c_e, c_Li, T):
@@ -24,6 +24,6 @@ def plating_exchange_current_density_OKane2020(c_e, c_Li, T):
         Exchange-current density [A.m-2]
     """
 
-    k_plating = 1e-10
+    k_plating = Parameter("Lithium plating kinetic rate constant [m.s-1]")
 
     return constants.F * k_plating * c_e
diff --git a/...ion/lithium_platings/okane2020_Li_plating/stripping_exchange_current_density_OKane2020.py b/...ion/lithium_platings/okane2020_Li_plating/stripping_exchange_current_density_OKane2020.py
@@ -1,4 +1,4 @@
-from pybamm import constants
+from pybamm import constants, Parameter
 
 
 def stripping_exchange_current_density_OKane2020(c_e, c_Li, T):
@@ -30,6 +30,6 @@ def stripping_exchange_current_density_OKane2020(c_e, c_Li, T):
         Exchange-current density [A.m-2]
     """
 
-    k_plating = 1e-10
+    k_plating = Parameter("Lithium plating kinetic rate constant [m.s-1]")
 
     return constants.F * k_plating * c_Li
diff --git a/pybamm/models/submodels/interface/lithium_plating/irreversible_plating.py b/pybamm/models/submodels/interface/lithium_plating/irreversible_plating.py
@@ -39,24 +39,19 @@ def get_fundamental_variables(self):
 
     def get_coupled_variables(self, variables):
         param = self.param
-        phi_s_n = variables[f"{self.domain} electrode potential"]
-        phi_e_n = variables[f"{self.domain} electrolyte potential"]
+        delta_phi = variables[f"{self.domain} electrode surface potential difference"]
         c_e_n = variables[f"{self.domain} electrolyte concentration"]
         T = variables[f"{self.domain} electrode temperature"]
+        eta_sei = variables[f"{self.domain} electrode SEI film overpotential"]
         c_plated_Li = variables[
             f"{self.domain} electrode lithium plating concentration"
         ]
         j0_plating = param.j0_plating(c_e_n, c_plated_Li, T)
-
-        eta_sei = variables[f"{self.domain} electrode SEI film overpotential"]
-
         phi_ref = param.U_n_ref / param.potential_scale
-
-        # need to revise for thermal case
+        eta_plating = -(delta_phi + phi_ref + eta_sei)
+        prefactor = 1 / (2 * (1 + self.param.Theta * T))
         # j_stripping is always negative, because there is no stripping, only plating
-        j_stripping = -j0_plating * (
-            pybamm.exp(-0.5 * (phi_s_n - phi_e_n + phi_ref + eta_sei))
-        )
+        j_stripping = -j0_plating * pybamm.exp(prefactor * eta_plating)
 
         variables.update(self._get_standard_reaction_variables(j_stripping))
 

diff --git a/pybamm/models/submodels/interface/lithium_plating/reversible_plating.py b/pybamm/models/submodels/interface/lithium_plating/reversible_plating.py
@@ -39,8 +39,7 @@ def get_fundamental_variables(self):
 
     def get_coupled_variables(self, variables):
         param = self.param
-        phi_s_n = variables[f"{self.domain} electrode potential"]
-        phi_e_n = variables[f"{self.domain} electrolyte potential"]
+        delta_phi = variables[f"{self.domain} electrode surface potential difference"]
         c_e_n = variables[f"{self.domain} electrolyte concentration"]
         T = variables[f"{self.domain} electrode temperature"]
         eta_sei = variables[f"{self.domain} electrode SEI film overpotential"]
@@ -50,11 +49,12 @@ def get_coupled_variables(self, variables):
         j0_stripping = param.j0_stripping(c_e_n, c_plated_Li, T)
         j0_plating = param.j0_plating(c_e_n, c_plated_Li, T)
         phi_ref = param.U_n_ref / param.potential_scale
-
-        # need to revise for thermal case
+        eta_stripping = delta_phi + phi_ref + eta_sei
+        eta_plating = -eta_stripping
+        prefactor = 1 / (2 * (1 + self.param.Theta * T))
         j_stripping = j0_stripping * pybamm.exp(
-            0.5 * (phi_s_n - phi_e_n + phi_ref + eta_sei)
-        ) - j0_plating * pybamm.exp(-0.5 * (phi_s_n - phi_e_n + phi_ref + eta_sei))
+            prefactor * eta_stripping
+        ) - j0_plating * pybamm.exp(prefactor * eta_plating)
 
         variables.update(self._get_standard_reaction_variables(j_stripping))
 

diff --git a/...st_models/test_submodels/test_interface/test_lithium_plating/test_irreversible_plating.py b/...st_models/test_submodels/test_interface/test_lithium_plating/test_irreversible_plating.py
@@ -15,11 +15,11 @@ def test_public_functions(self):
             pybamm.Scalar(0), ["negative electrode"], "current collector"
         )
         variables = {
-            "Negative electrode potential": a_n,
-            "Negative electrolyte potential": a_n,
+            "Negative electrode surface potential difference": a_n,
             "Negative electrolyte concentration": a_n,
             "Negative electrode temperature": a_n,
             "Negative electrode SEI film overpotential": a_n,
+            "Negative electrode lithium plating concentration": a_n
         }
         submodel = pybamm.lithium_plating.IrreversiblePlating(param, "Negative")
         std_tests = tests.StandardSubModelTests(submodel, variables)

diff --git a/...test_models/test_submodels/test_interface/test_lithium_plating/test_reversible_plating.py b/...test_models/test_submodels/test_interface/test_lithium_plating/test_reversible_plating.py
@@ -22,9 +22,8 @@ def test_public_functions(self):
             pybamm.Scalar(0), ["negative electrode"], "current collector"
         )
         variables = {
-            "Negative electrode potential": a_n,
+            "Negative electrode surface potential difference": a_n,
             "Negative electrode temperature": a_n,
-            "Negative electrolyte potential": a_n,
             "Negative electrolyte concentration": a_n,
             "Negative electrode lithium plating concentration": a_n,
             "Negative electrode SEI film overpotential": a_n,