Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1393 end simulation when experiment infeasible #1395

Merged
merged 2 commits into from
Feb 22, 2021

Conversation

rtimms
Copy link
Contributor

@rtimms rtimms commented Feb 19, 2021

Description

Makes it so that simulations stop when an experiment becomes infeasible

Fixes #1393

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

Copy link
Member

@valentinsulzer valentinsulzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #1395 (f7f2dde) into develop (32db967) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1395   +/-   ##
========================================
  Coverage    98.25%   98.25%           
========================================
  Files          277      277           
  Lines        15687    15691    +4     
========================================
+ Hits         15413    15417    +4     
  Misses         274      274           
Impacted Files Coverage Δ
pybamm/simulation.py 97.20% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32db967...f7f2dde. Read the comment docs.

@rtimms rtimms merged commit e1c7273 into develop Feb 22, 2021
@rtimms rtimms deleted the issue-1393-infeasible-experiment branch February 22, 2021 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop simulation when experiment infeasible
2 participants