Skip to content

Commit

Permalink
#1393 changelog
Browse files Browse the repository at this point in the history
  • Loading branch information
rtimms committed Feb 22, 2021
1 parent 1c7a19f commit f7f2dde
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@

## Bug fixes

- Simulations now stop when an experiment becomes infeasible ([#1395](https://github.com/pybamm-team/PyBaMM/pull/1395))
- Added a check for domains in `Concatenation` ([#1368](https://github.com/pybamm-team/PyBaMM/pull/1368))
- Differentiation now works even when the differentiation variable is a constant ([#1294](https://github.com/pybamm-team/PyBaMM/pull/1294))
- Fixed a bug where the event time and state were no longer returned as part of the solution ([#1344](https://github.com/pybamm-team/PyBaMM/pull/1344))
Expand Down
6 changes: 3 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ If you want to check integration tests as well as unit tests, type
```bash
tox -e tests # (GNU/Linux and MacOS)
#
python -m tox -e windows-tests (Windows)
python -m tox -e windows-tests # (Windows)
```

When you commit anything to PyBaMM, these checks will also be run automatically (see [infrastructure](#infrastructure)).
Expand All @@ -216,7 +216,7 @@ To test all example scripts and notebooks, type
```bash
tox -e examples # (GNU/Linux and MacOS)
#
python -m tox -e windows-examples (Windows)
python -m tox -e windows-examples # (Windows)
```

If notebooks fail because of changes to pybamm, it can be a bit of a hassle to debug. In these cases, you can create a temporary export of a notebook's Python content using
Expand Down Expand Up @@ -340,7 +340,7 @@ Where possible, notebooks are tested daily. A list of slow notebooks (which time

## Citations

We aim to recognize all contributions by automatically generating citations to the relevant papers on which different parts of the code are built.
We aim to recognize all contributions by automatically generating citations to the relevant papers on which different parts of the code are built.
These will change depending on what models and solvers you use.
Adding the command

Expand Down

0 comments on commit f7f2dde

Please sign in to comment.