Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 0.2.4 #1139

Merged
merged 346 commits into from
Sep 7, 2020
Merged

Release 0.2.4 #1139

merged 346 commits into from
Sep 7, 2020

Conversation

valentinsulzer
Copy link
Member

Merging develop into master for new release

martinjrobins and others added 30 commits July 2, 2020 19:57
@martinjrobins
#1031 fix windows import errors
779543e
@valentinsulzer
#1082 trying sensitivity on DFN. works but slow
156fcb7
@valentinsulzer
Merge branch 'develop' into issue-1082-casadi-sensitivity
d9a690e
@martinjrobins
#1031 improve test coverage
fcb6269
@martinjrobins
#1031 test evaluator jax jacobian and debug
f294039
@martinjrobins
#1031 improve coverage
284521b
@rtimms
#1084 allow kwargs to be passed to sim.plot
a84d63a
@rtimms
#1084 changelog
75ecbae
@rtimms
#1084 deprecation error
201cdb6
@martinjrobins
#1031 fix typo in docstring
74d4ba7
@martinjrobins
#1031 fix doctring for bdf init function
b8e9030
@martinjrobins
#1031 remove commented out code
44df73b
@martinjrobins
#1031 give more details when jax solver fails due to terminate event
a30ddf0
@martinjrobins
Merge pull request #1038 from pybamm-team/issue-1031-jax
5ff13ed 
Issue 1031 jax
@rtimms
#1084 swap parameter order
a83b2fb
@valentinsulzer
Merge branch 'develop' into issue-1082-casadi-sensitivity
2c6e159
@valentinsulzer
#1082 add entries as attribute
29d617a
@rtimms
Merge pull request #1099 from pybamm-team/issue-1084-kwargs-sim-plot
b2488ce 
#1084 allow kwargs to be passed to sim.plot
@valentinsulzer
#1082 trying to figure out adjoints
9b8bac3
@martinjrobins
#1031 start to reformat jax_bdf_integrate to fit with jax custom_vjp …
aede5c1 
…code
@martinjrobins
#1031 add a sensitivities test
dbea36b
@martinjrobins
#1031 add fix for int captured args to fun
3cd80d3
@martinjrobins
#1031 swap to using fun(y, t)
003bbc4
@martinjrobins
#1031 try to improve performance on autodiff of solver
0330cdc
@martinjrobins
#1031 finalise sensitivity test for jax_bdf_solver
c74c35e
@martinjrobins
#1031 add test for sensitivities with jax solver
610d215
@martinjrobins
#1031 fix flake8 errors
ebe7109
@martinjrobins
#1031 fix tests
d8b9a32
@martinjrobins
#1031 fix more tests
ce39947
@martinjrobins
#1031 fix test
7b27581
Thibault Lestang and others added 24 commits August 28, 2020 13:55
Mention that idaklu solver is not available on Windows
815bf54
Modify structure if tox.ini to use more conditionals
567adea
Update workflow file
d1825d3
Fix syntax error in docs
79a8738
Fix name of tox testenv
f12541a
Update CONTRIBUTING.md with more tox commands
c447095
Update structure of source install doc
ab1fc4c
Update pre-commit checks section in CONTRIBUTING.md with more tox com…
c909e14 
…mands
@valentinsulzer
Merge pull request #996 from pybamm-team/tox
cfef53a 
Use Tox
@valentinsulzer
Merge branch 'develop' into issue-1126-upwind
6d79c12
@valentinsulzer
#1126 coverage
d1a3bee
@rtimms
Merge pull request #1131 from pybamm-team/issue-1127-extra-notebooks
377fc45 
Issue 1127 extra notebooks
@rtimms
remove pkl files from examples folder
7e9b58e
@valentinsulzer
#1126 changelog
6ac182b
@valentinsulzer
Merge pull request #1134 from pybamm-team/issue-1126-upwind
b9db700 
Issue 1126 upwind
@rtimms
Merge branch 'develop' of https://github.com/pybamm-team/PyBaMM into …
208c010 
…develop
@rtimms
Merge branch 'develop' into issue-1112-EC-sei-params
71444db
@rtimms
#1112 reformat EC sei model
ebcbafd
@rtimms
#1112 Tino comments
fec561f
@rtimms
#1112 fix examples
6d5ede2
@rtimms
#1112 fix examples
e5fd81a
@valentinsulzer
Merge pull request #1136 from pybamm-team/issue-1112-EC-sei-params
f5a2233 
Issue 1112 ec sei params
@valentinsulzer
changes for release 0.2.4
36917e1
@valentinsulzer
Merge pull request #1138 from pybamm-team/release-0.2.4
c320ad7 
changes for release 0.2.4
brosaplanella
brosaplanella approved these changes Sep 7, 2020
View reviewed changes
Copy link
Member

@brosaplanella brosaplanella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks Tino :)

@brosaplanella
Copy link
Member

BTW, in CONTRIBUTING.md (line 373) we still mention Binder. Should we remove it/change it for Colab?

@valentinsulzer
Copy link
Member Author

Yeah we should change that, doesn't need to be this release though

@valentinsulzer valentinsulzer merged commit f00b8d1 into master Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brosaplanella brosaplanella brosaplanella approved these changes

@rtimms rtimms Awaiting requested review from rtimms

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@valentinsulzer @brosaplanella @martinjrobins @rtimms @YannickNoelStephanKuhn @tlestang @TomTranter