Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass keyword args to sim.plot() #1084

Closed
rtimms opened this issue Jun 29, 2020 · 1 comment · Fixed by #1099
Closed

pass keyword args to sim.plot() #1084

rtimms opened this issue Jun 29, 2020 · 1 comment · Fixed by #1099

Comments

@rtimms
Copy link
Contributor

rtimms commented Jun 29, 2020

It would be handy to be able to pass keyword args to sim.plot() (e.g. time_unit) in the same way you can when using pybamm.dynamic_plot
@valentinsulzer
Copy link
Member

Should also rename quick_plot_vars to output_variables for consistency

rtimms added a commit that referenced this issue Jul 6, 2020
@rtimms
#1084 allow kwargs to be passed to sim.plot
a84d63a
@rtimms rtimms mentioned this issue Jul 6, 2020
Merged
8 tasks
rtimms added a commit that referenced this issue Jul 6, 2020
@rtimms
#1084 changelog
75ecbae
rtimms added a commit that referenced this issue Jul 7, 2020
@rtimms
#1084 deprecation error
201cdb6
rtimms added a commit that referenced this issue Jul 7, 2020
@rtimms
#1084 swap parameter order
a83b2fb
rtimms added a commit that referenced this issue Jul 8, 2020
@rtimms
Merge pull request #1099 from pybamm-team/issue-1084-kwargs-sim-plot
b2488ce 
#1084 allow kwargs to be passed to sim.plot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#1084 allow kwargs to be passed to sim.plot pybamm-team/PyBaMM
2 participants
@valentinsulzer @rtimms