Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1105 use approximated step size for D and c calculation #1106

Merged
merged 1 commit into from
Jul 13, 2020

Conversation

martinjrobins
Copy link
Contributor

@martinjrobins martinjrobins commented Jul 12, 2020

Description

Fixes #1105

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Jul 12, 2020

Codecov Report

Merging #1106 into develop will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1106   +/-   ##
========================================
  Coverage    97.81%   97.81%           
========================================
  Files          245      245           
  Lines        13179    13179           
========================================
  Hits         12891    12891           
  Misses         288      288           
Impacted Files Coverage Δ
pybamm/solvers/jax_bdf_solver.py 99.39% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2488ce...3559529. Read the comment docs.

@martinjrobins martinjrobins merged commit 4d10b27 into develop Jul 13, 2020
@valentinsulzer valentinsulzer deleted the issue-1105-fix-bdf-init branch November 3, 2021 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jax bdf solver does not initialise difference equations correctly according to step size
2 participants