Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jax bdf solver does not initialise difference equations correctly according to step size #1105

Closed
martinjrobins opened this issue Jul 12, 2020 · 0 comments · Fixed by #1106
Closed

jax bdf solver does not initialise difference equations correctly according to step size #1105

martinjrobins opened this issue Jul 12, 2020 · 0 comments · Fixed by #1106
Assignees
@martinjrobins

Comments

@martinjrobins
Copy link
Contributor

step size is approximated during bdf_init, but the new step size is not used to calculate the difference equations or c const
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martinjrobins martinjrobins

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#1105 use approximated step size for D and c calculation pybamm-team/PyBaMM
1 participant
@martinjrobins