Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify all objects on creation #1230

Closed
valentinsulzer opened this issue Nov 4, 2020 · 1 comment · Fixed by #1252
Closed

Simplify all objects on creation #1230

valentinsulzer opened this issue Nov 4, 2020 · 1 comment · Fixed by #1252
Assignees
@valentinsulzer

Comments

@valentinsulzer
Copy link
Member

valentinsulzer commented Nov 4, 2020 •
edited
Loading

Instead of just simplifying if constant.
See also #986
@valentinsulzer valentinsulzer self-assigned this Nov 4, 2020
valentinsulzer added a commit that referenced this issue Nov 15, 2020
@valentinsulzer
#1230 trying harder simplify, gets recursion errors
07356d2
valentinsulzer added a commit that referenced this issue Nov 15, 2020
@valentinsulzer
#1230 merge develop
2e69bd6
valentinsulzer added a commit that referenced this issue Nov 15, 2020
@valentinsulzer
#1230 adding simplifications, need to be careful about domains
23266fd
valentinsulzer added a commit that referenced this issue Nov 15, 2020
@valentinsulzer
#1230 fix domains
3a33d92
valentinsulzer added a commit that referenced this issue Nov 15, 2020
@valentinsulzer
#1230 merge develop
4fe6879
valentinsulzer added a commit that referenced this issue Nov 15, 2020
@valentinsulzer
#1230 flake8
240b50f
valentinsulzer added a commit that referenced this issue Nov 17, 2020
@valentinsulzer
#1230 merge develop
8b6e5d7
valentinsulzer added a commit that referenced this issue Nov 17, 2020
@valentinsulzer
#1230 fix tests
f4e75c6
This was referenced Nov 17, 2020
Closed
Merged
valentinsulzer added a commit that referenced this issue Nov 17, 2020
@valentinsulzer
#1230 changelog
4a27af1
valentinsulzer added a commit that referenced this issue Nov 18, 2020
@valentinsulzer
#1230 fix tests
5d1706b
valentinsulzer added a commit that referenced this issue Nov 18, 2020
@valentinsulzer
#1230 flake8
1efb278
valentinsulzer added a commit that referenced this issue Nov 18, 2020
@valentinsulzer
#1230 create TimerTime class for automatic formatting when printing
bc8063e
valentinsulzer added a commit that referenced this issue Nov 18, 2020
@valentinsulzer
#1230 fix tests
b804f1d
valentinsulzer added a commit that referenced this issue Nov 18, 2020
@valentinsulzer
#1230 fixing tests
1b68f76
@valentinsulzer
Copy link
Member Author

Further simplifications for matrix multiplications:

  • associative: A @ (B @ y) = (A @ B) @ y), often A @ B is constant but y is not (e.g. discretized gradient or divergence) and so the whole expression is simplified
  • distributive A @ (B + C) = (A @ B + A @ C), in many cases A @ B is constant and then A @ C can be further simplified (e.g. A @ (b + C @ y) + e = (A @ b + e) + (A @ C) @ y, A @ b + e is constant and A @ C is constant

valentinsulzer added a commit that referenced this issue Nov 18, 2020
@valentinsulzer
#1230 still fixing tests
07c9c66
valentinsulzer added a commit that referenced this issue Nov 22, 2020
@valentinsulzer
#1230 fix tests for smoothing
172098a
valentinsulzer added a commit that referenced this issue Nov 22, 2020
@valentinsulzer
#1230 fix tests
d4d0b35
valentinsulzer added a commit that referenced this issue Nov 23, 2020
@valentinsulzer
#1230 fixign tests
3ccf4b0
valentinsulzer added a commit that referenced this issue Nov 23, 2020
@valentinsulzer
#1230 fix docs
71df969
valentinsulzer added a commit that referenced this issue Nov 23, 2020
@valentinsulzer
#1230 fix run-tests.py
0979f42
valentinsulzer added a commit that referenced this issue Nov 23, 2020
@valentinsulzer
#1230 fix examples
ec4e125
valentinsulzer added a commit that referenced this issue Nov 24, 2020
@valentinsulzer
#1230 coverage
f1134a9
valentinsulzer added a commit that referenced this issue Nov 24, 2020
@valentinsulzer
#1230 fix tests and remove commented out code
82fe27a
valentinsulzer added a commit that referenced this issue Dec 9, 2020
@valentinsulzer
#1129 merge #1230
592d4c8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valentinsulzer valentinsulzer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 1230 simplify pybamm-team/PyBaMM
1 participant
@valentinsulzer