Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate Julia code from a pybamm expression tree #1129

Closed
valentinsulzer opened this issue Aug 19, 2020 · 1 comment · Fixed by #1942
Closed

Generate Julia code from a pybamm expression tree #1129

valentinsulzer opened this issue Aug 19, 2020 · 1 comment · Fixed by #1942
Assignees
@valentinsulzer

Comments

@valentinsulzer
Copy link
Member

Mimic EvaluatorPython to generate a Julia function from an expression tree.
The first step is to generate a pure Julia function.
Later on, we can generate functions in the ModelingToolkit.jl format
@valentinsulzer valentinsulzer self-assigned this Aug 19, 2020
valentinsulzer added a commit that referenced this issue Oct 28, 2020
@valentinsulzer
#1129 get more simple scalars and functions working
d2ad43a
valentinsulzer added a commit that referenced this issue Oct 28, 2020
@valentinsulzer
#1129 start matrix operations
aa0b0b4
valentinsulzer added a commit that referenced this issue Oct 28, 2020
@valentinsulzer
#1129 add sparse arrays
f613bc2
valentinsulzer added a commit that referenced this issue Oct 28, 2020
@valentinsulzer
#1129 test div and grad
0e3d72e
valentinsulzer added a commit that referenced this issue Oct 28, 2020
@valentinsulzer
#1129 flatten column vectors
7c7cd6a
valentinsulzer added a commit that referenced this issue Oct 28, 2020
@valentinsulzer
#1129 tests
7b8d093
valentinsulzer added a commit that referenced this issue Oct 28, 2020
@valentinsulzer
#1129 generating MTK model
bb62953
valentinsulzer added a commit that referenced this issue Oct 28, 2020
@valentinsulzer
#1129 cleaning up a bit
5494ea3
valentinsulzer added a commit that referenced this issue Oct 28, 2020
@valentinsulzer
#1129 adding tests
cbf7acb
valentinsulzer added a commit that referenced this issue Oct 28, 2020
@valentinsulzer
#1129 add a test using parameters
88c217f
valentinsulzer added a commit that referenced this issue Oct 28, 2020
@valentinsulzer
#1129 add support for DAE model
831fe2e
valentinsulzer added a commit that referenced this issue Oct 28, 2020
@valentinsulzer
#1129 flake8
e40104f
valentinsulzer added a commit that referenced this issue Oct 28, 2020
@valentinsulzer
#1129 move constants outside of function
4496993
valentinsulzer added a commit that referenced this issue Oct 30, 2020
@valentinsulzer
#1129 starting to optimize generated function
3dff3bb
valentinsulzer added a commit that referenced this issue Oct 30, 2020
@valentinsulzer
#1129 testing some inplace stuff
b71ee46
valentinsulzer added a commit that referenced this issue Oct 30, 2020
@valentinsulzer
#1129 investigating pyjulia issue
60db480
valentinsulzer added a commit that referenced this issue Oct 30, 2020
@valentinsulzer
#1129 use mul! and cache variables
c7d1753
valentinsulzer added a commit that referenced this issue Oct 30, 2020
@valentinsulzer
#1129 inlining operations and starting vcat alternative
9086148
valentinsulzer added a commit that referenced this issue Oct 30, 2020
@valentinsulzer
#1129 fix concatenations, start adding tests
da47078
valentinsulzer added a commit that referenced this issue Dec 9, 2020
@valentinsulzer
#1129 working through more cases
af06122
valentinsulzer added a commit that referenced this issue Dec 9, 2020
@valentinsulzer
#1129 all tests pass but not simplifying enough
6929b32
valentinsulzer added a commit that referenced this issue Dec 9, 2020
@valentinsulzer
#1129 all evaluate_julia tests passing
5fa4f8d
valentinsulzer added a commit that referenced this issue Dec 9, 2020
@valentinsulzer
#1129 working on battery models
f595ae2
valentinsulzer added a commit that referenced this issue Dec 9, 2020
@valentinsulzer
#1129 debugging julia models
f415d55
valentinsulzer added a commit that referenced this issue Dec 9, 2020
@valentinsulzer
#1129 merge #1230
592d4c8
valentinsulzer added a commit that referenced this issue Dec 9, 2020
@valentinsulzer
#1129 running more tests, DFN is wrong
bec5ce3
valentinsulzer added a commit that referenced this issue Dec 9, 2020
@valentinsulzer
#1129 running more julia tests
f3e4936
valentinsulzer added a commit that referenced this issue Dec 9, 2020
@valentinsulzer
#1129 merge develop
f619f64
valentinsulzer added a commit that referenced this issue Dec 9, 2020
@valentinsulzer
#1129 debugging DFN
fef5d0c
valentinsulzer added a commit that referenced this issue Aug 31, 2021
@valentinsulzer
#1129 merge develop
ebb5d3f
valentinsulzer added a commit that referenced this issue Sep 18, 2021
@valentinsulzer
#1129 merge develop
fc2b1c6
valentinsulzer added a commit that referenced this issue Sep 18, 2021
@valentinsulzer
#1129 fix julia tests
0050d42
valentinsulzer added a commit that referenced this issue Sep 18, 2021
@valentinsulzer
#1129 skip julia on windows and python3.9
d7dc913
valentinsulzer added a commit that referenced this issue Sep 20, 2021
@valentinsulzer
#1129 don't install julia on ubuntu wuth python 3.9
d99a2f8
valentinsulzer added a commit that referenced this issue Dec 14, 2021
@valentinsulzer
#1129 merge develop
904c5e0
valentinsulzer added a commit that referenced this issue Dec 14, 2021
@valentinsulzer
#1129 fix julia generation for discretized equations
61b6f13
valentinsulzer added a commit that referenced this issue Dec 14, 2021
@valentinsulzer
#1129 fix mtk model generation
802966d
valentinsulzer added a commit that referenced this issue Dec 14, 2021
@valentinsulzer
#1129 merge develop
3774e28
valentinsulzer added a commit that referenced this issue Dec 14, 2021
@valentinsulzer
#1129 fix print_names
a12a967
valentinsulzer added a commit that referenced this issue Feb 2, 2022
@valentinsulzer
#1129 merge develop
fa8ecc1
valentinsulzer added a commit that referenced this issue Feb 2, 2022
@valentinsulzer
#1129 fix tests
e27db82
valentinsulzer added a commit that referenced this issue Feb 3, 2022
@valentinsulzer
#1129 julia on linux only
3e5373a
valentinsulzer added a commit that referenced this issue Feb 3, 2022
@valentinsulzer
#1129 try python 3.9
8c14f80
valentinsulzer added a commit that referenced this issue Feb 3, 2022
@valentinsulzer
#1129 try julia tests on mac
735b5ae
@valentinsulzer valentinsulzer mentioned this issue Feb 17, 2022
Merged
8 tasks
valentinsulzer added a commit that referenced this issue Feb 17, 2022
@valentinsulzer
#1129 minor debugging
7f737d2
valentinsulzer added a commit that referenced this issue Feb 17, 2022
@valentinsulzer
#1129 add rounding
6886069
valentinsulzer added a commit that referenced this issue Feb 18, 2022
@valentinsulzer
#1129 remove test.py
a473140
valentinsulzer added a commit that referenced this issue Mar 4, 2022
@valentinsulzer
#1129 remove imports
05f11a5
valentinsulzer added a commit that referenced this issue Mar 8, 2022
@valentinsulzer
#1129 add more tests
2e80558
valentinsulzer added a commit that referenced this issue Mar 8, 2022
@valentinsulzer
#1129 add model tests for MTK
754c502
valentinsulzer added a commit that referenced this issue Mar 11, 2022
@valentinsulzer
#1129 coverage
81a01a5
valentinsulzer added a commit that referenced this issue Mar 15, 2022
@valentinsulzer
#1129 coverage
4b9b2a4
valentinsulzer added a commit that referenced this issue Mar 15, 2022
@valentinsulzer
#1129 coverage
d037ed5
valentinsulzer added a commit that referenced this issue Mar 15, 2022
@valentinsulzer
#1129 changelog
183e441
valentinsulzer added a commit that referenced this issue Mar 16, 2022
@valentinsulzer
#1129 fix min/max
81d0261
valentinsulzer added a commit that referenced this issue Apr 22, 2022
@valentinsulzer
#1129 need to work on preallocate=False
c7948b9
valentinsulzer added a commit that referenced this issue May 26, 2022
@valentinsulzer
#1129 fix preallocating tests
b71c20b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valentinsulzer valentinsulzer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 1129 julia pybamm-team/PyBaMM
1 participant
@valentinsulzer